lib: move function declaration outside of loop

PR-URL: #51242 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs · Jan 2, 2024 · 8f845eb · 8f845eb
1 parent 6648a5c
commit 8f845eb
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/internal/per_context/primordials.js b/lib/internal/per_context/primordials.js
@@ -541,11 +541,14 @@ primordials.SafePromiseAllReturnVoid = (promises, mapFn) =>
   new Promise((resolve, reject) => {
     let pendingPromises = promises.length;
     if (pendingPromises === 0) resolve();
+    const onFulfilled = () => {
+      if (--pendingPromises === 0) {
+        resolve();
+      }
+    };
     for (let i = 0; i < promises.length; i++) {
       const promise = mapFn != null ? mapFn(promises[i], i) : promises[i];
-      PromisePrototypeThen(PromiseResolve(promise), () => {
-        if (--pendingPromises === 0) resolve();
-      }, reject);
+      PromisePrototypeThen(PromiseResolve(promise), onFulfilled, reject);
     }
   });