http2: fix potential integer overflow

Fix report from coverity on potential integer overflow in http2. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #42248 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
nodejs · Mar 20, 2022 · 88dee3c · 88dee3c
1 parent 701dc14
commit 88dee3c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -197,7 +197,8 @@ Http2Options::Http2Options(Http2State* http2_state, SessionType type) {
   // Important: The maxSessionMemory option in javascript is expressed in
   //            terms of MB increments (i.e. the value 1 == 1 MB)
   if (flags & (1 << IDX_OPTIONS_MAX_SESSION_MEMORY))
-    set_max_session_memory(buffer[IDX_OPTIONS_MAX_SESSION_MEMORY] * 1000000);
+    set_max_session_memory(buffer[IDX_OPTIONS_MAX_SESSION_MEMORY] *
+                           static_cast<uint64_t>(1000000));
 
   if (flags & (1 << IDX_OPTIONS_MAX_SETTINGS)) {
     nghttp2_option_set_max_settings(