test: remove common.PORT from test-net-timeout

Switch test-net-timeout from common.PORT to a port assigned by the operating system. PR-URL: #31749 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Feb 27, 2020 · 724bf31 · 724bf31
1 parent 98d262e
commit 724bf31
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/test/pummel/test-net-timeout.js b/test/pummel/test-net-timeout.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 const net = require('net');
 
@@ -54,10 +54,11 @@ const echo_server = net.createServer((socket) => {
   });
 });
 
-echo_server.listen(common.PORT, () => {
-  console.log(`server listening at ${common.PORT}`);
+echo_server.listen(0, () => {
+  const port = echo_server.address().port;
+  console.log(`server listening at ${port}`);
 
-  const client = net.createConnection(common.PORT);
+  const client = net.createConnection(port);
   client.setEncoding('UTF8');
   client.setTimeout(0); // Disable the timeout for client
   client.on('connect', () => {