From 6e4fa6a08328a94d86911b0db061fc8643b16bb8 Mon Sep 17 00:00:00 2001 From: Nikhil Komawar Date: Thu, 12 Oct 2017 16:47:29 -0400 Subject: [PATCH] tools: rename unused variale in more pythonic way The 'Main' function in tools/test.py file was using a variable named ``all_outcomes`` to store a value not being used. It is a best practice to name unused variables, often return values of functions/methods (as in this case) as ``_`` [1]. This just helps keep the code a bit cleaner and avoid any silly mistakes. PR-URL: https://github.com/nodejs/node/pull/16171 Refs: [1] https://stackoverflow.com/a/5477153 Reviewed-By: James M Snell Reviewed-By: Claudio Rodriguez Reviewed-By: Gireesh Punathil Reviewed-By: Colin Ihrig Reviewed-By: Ruben Bridgewater --- tools/test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test.py b/tools/test.py index 207f39ebfce1ed..e7c01c8658b23d 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1578,7 +1578,7 @@ def Main(): } test_list = root.ListTests([], path, context, arch, mode) unclassified_tests += test_list - (cases, unused_rules, all_outcomes) = ( + (cases, unused_rules, _) = ( config.ClassifyTests(test_list, env)) if globally_unused_rules is None: globally_unused_rules = set(unused_rules)