util: only the first line of the error message

V8 extends the error message for JSON#stringify when encountering circular structures. The first line of the new error message is equivalent to the old error message and stays the same across all circular structure errors. PR-URL: #26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
nodejs · Mar 28, 2019 · 63e13fd · 63e13fd
1 parent 3b5773f
commit 63e13fd
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -1373,6 +1373,7 @@ function format(...args) {
 }
 
 
+const firstErrorLine = (error) => error.message.split('\n')[0];
 let CIRCULAR_ERROR_MESSAGE;
 function tryStringify(arg) {
   try {
@@ -1383,11 +1384,13 @@ function tryStringify(arg) {
       try {
         const a = {}; a.a = a; JSON.stringify(a);
       } catch (err) {
-        CIRCULAR_ERROR_MESSAGE = err.message;
+        CIRCULAR_ERROR_MESSAGE = firstErrorLine(err);
       }
     }
-    if (err.name === 'TypeError' && err.message === CIRCULAR_ERROR_MESSAGE)
+    if (err.name === 'TypeError' &&
+        firstErrorLine(err) === CIRCULAR_ERROR_MESSAGE) {
       return '[Circular]';
+    }
     throw err;
   }
 }