util: removing redundant checks in is* functions

When Object.prototype.toString is used to determine the type, we don't have to explicitly check for other types. This patch removes the redundant checks like that. PR-URL: #2179 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
nodejs · Jul 21, 2015 · 6391f4d · 6391f4d
1 parent b612f08
commit 6391f4d
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -607,8 +607,7 @@ function isUndefined(arg) {
 exports.isUndefined = isUndefined;
 
 function isRegExp(re) {
-  return re !== null && typeof re === 'object' &&
-         objectToString(re) === '[object RegExp]';
+  return objectToString(re) === '[object RegExp]';
 }
 exports.isRegExp = isRegExp;
 
@@ -618,14 +617,12 @@ function isObject(arg) {
 exports.isObject = isObject;
 
 function isDate(d) {
-  return d !== null && typeof d === 'object' &&
-         objectToString(d) === '[object Date]';
+  return objectToString(d) === '[object Date]';
 }
 exports.isDate = isDate;
 
 function isError(e) {
-  return e !== null && typeof e === 'object' &&
-      (objectToString(e) === '[object Error]' || e instanceof Error);
+  return objectToString(e) === '[object Error]' || e instanceof Error;
 }
 exports.isError = isError;