lib: fix stack overflow check to not break on primitives

PR-URL: #28338 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Jul 2, 2019 · 5f9ee9f · 5f9ee9f
1 parent 937afcc
commit 5f9ee9f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -582,7 +582,7 @@ function isStackOverflowError(err) {
     }
   }
 
-  return err.name === maxStack_ErrorName &&
+  return err && err.name === maxStack_ErrorName &&
          err.message === maxStack_ErrorMessage;
 }
 

diff --git a/test/parallel/test-console-log-throw-primitive.js b/test/parallel/test-console-log-throw-primitive.js
@@ -0,0 +1,14 @@
+'use strict';
+require('../common');
+const { Writable } = require('stream');
+const { Console } = require('console');
+
+const stream = new Writable({
+  write() {
+    throw null; // eslint-disable-line no-throw-literal
+  }
+});
+
+const console = new Console({ stdout: stream });
+
+console.log('test'); // Should not throw
-Original file line number
+Diff line change
@@ Expand Up / @@ -582,7 +582,7 @@ function isStackOverflowError(err) { @@
         }
       }
-      return err.name === maxStack_ErrorName &&
+      return err && err.name === maxStack_ErrorName &&
              err.message === maxStack_ErrorMessage;
     }
@@ Expand Down @@