fs: use fs.access in fs.exists

Uses fs.access to implement fs.exists functionality. Fixes a issue, when a file exists but user does not have privileges to do stat on the file. Fixes: #17921 Backport-PR-URL: #19654 PR-URL: #18618 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Apr 4, 2018 · 5e90fc6 · 5e90fc6
1 parent ae86adc
commit 5e90fc6
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -323,12 +323,7 @@ fs.accessSync = function(path, mode) {
 };
 
 fs.exists = function(path, callback) {
-  if (handleError((path = getPathFromURL(path)), cb))
-    return;
-  if (!nullCheck(path, cb)) return;
-  var req = new FSReqWrap();
-  req.oncomplete = cb;
-  binding.stat(pathModule.toNamespacedPath(path), req);
+  fs.access(path, fs.F_OK, cb);
   function cb(err) {
     if (callback) callback(err ? false : true);
   }
@@ -345,9 +340,7 @@ Object.defineProperty(fs.exists, internalUtil.promisify.custom, {
 
 fs.existsSync = function(path) {
   try {
-    handleError((path = getPathFromURL(path)));
-    nullCheck(path);
-    binding.stat(pathModule.toNamespacedPath(path));
+    fs.accessSync(path, fs.F_OK);
     return true;
   } catch (e) {
     return false;