diff --git a/lib/internal/worker.js b/lib/internal/worker.js index 1640a9dd88a2ba..da663798148441 100644 --- a/lib/internal/worker.js +++ b/lib/internal/worker.js @@ -184,6 +184,8 @@ class Worker extends EventEmitter { } postMessage(...args) { + if (this[kPublicPort] === null) return; + this[kPublicPort].postMessage(...args); } @@ -219,14 +221,20 @@ class Worker extends EventEmitter { } get stdin() { + if (this[kParentSideStdio] === null) return null; + return this[kParentSideStdio].stdin; } get stdout() { + if (this[kParentSideStdio] === null) return null; + return this[kParentSideStdio].stdout; } get stderr() { + if (this[kParentSideStdio] === null) return null; + return this[kParentSideStdio].stderr; } } diff --git a/test/parallel/test-worker-safe-getters.js b/test/parallel/test-worker-safe-getters.js new file mode 100644 index 00000000000000..23c8de7c7b0cfb --- /dev/null +++ b/test/parallel/test-worker-safe-getters.js @@ -0,0 +1,38 @@ +'use strict'; + +const common = require('../common'); + +const assert = require('assert'); +const { Worker, isMainThread } = require('worker_threads'); + +if (isMainThread) { + const w = new Worker(__filename, { + stdin: true, + stdout: true, + stderr: true + }); + + w.on('exit', common.mustCall((code) => { + assert.strictEqual(code, 0); + + // `postMessage` should not throw after termination + // (this mimics the browser behavior). + w.postMessage('foobar'); + w.ref(); + w.unref(); + + // Although not browser specific, probably wise to + // make sure the stream getters don't throw either. + w.stdin; + w.stdout; + w.stderr; + + // Sanity check. + assert.strictEqual(w.threadId, -1); + assert.strictEqual(w.stdin, null); + assert.strictEqual(w.stdout, null); + assert.strictEqual(w.stderr, null); + })); +} else { + process.exit(0); +}