From 5c71ea151ade9c50a7b3b7c832e3d6d14542ca56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> Date: Tue, 8 Dec 2020 08:06:38 +0100 Subject: [PATCH] deps: V8: cherry-pick fbb28902e049 Original commit message: Update V8 postmortem metadata script This commit updates the gen-postmortem-metadata.py script to incorporate changes in V8 8.4. This removes the need to float a patch to the script in Node.js. Change-Id: I69da40e792f22748b0eee2952b9009b2f03d13f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565275 Reviewed-by: Joyee Cheung <joyee@igalia.com> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/master@{#71646} Refs: https://github.com/v8/v8/commit/fbb28902e0494c47451492d396a69475edacb140 PR-URL: https://github.com/nodejs/node/pull/36139 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> --- common.gypi | 2 +- deps/v8/tools/gen-postmortem-metadata.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index be7c06d4c81882..e5f01195e63850 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.11', + 'v8_embedder_string': '-node.12', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py index 4e9facd7818402..70714f184882e3 100644 --- a/deps/v8/tools/gen-postmortem-metadata.py +++ b/deps/v8/tools/gen-postmortem-metadata.py @@ -287,6 +287,7 @@ 'SlicedString, offset, SMI, kOffsetOffset', 'ThinString, actual, String, kActualOffset', 'Symbol, name, Object, kDescriptionOffset', + 'FixedArrayBase, length, SMI, kLengthOffset', ]; #