Skip to content

Commit

Permalink
lib: add navigator.userAgent
Browse files Browse the repository at this point in the history
PR-URL: #50200
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
  • Loading branch information
anonrig authored and targos committed Oct 23, 2023
1 parent a362c27 commit 5a52c51
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 0 deletions.
15 changes: 15 additions & 0 deletions doc/api/globals.md
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,21 @@ logical processors available to the current Node.js instance.
console.log(`This process is running on ${navigator.hardwareConcurrency}`);
```

### `navigator.userAgent`

<!-- YAML
added: REPLACEME
-->

* {string}

The `navigator.userAgent` read-only property returns user agent
consisting of the runtime name and major version number.

```js
console.log(`The user-agent is ${navigator.userAgent}`); // Prints "Node.js/21"
```

## `PerformanceEntry`

<!-- YAML
Expand Down
10 changes: 10 additions & 0 deletions lib/internal/navigator.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ const {
} = internalBinding('os');

const kInitialize = Symbol('kInitialize');
const nodeVersion = process.version;

class Navigator {
// Private properties are used to avoid brand validations.
#availableParallelism;
#userAgent = `Node.js/${nodeVersion.slice(1, nodeVersion.indexOf('.'))}`;

constructor() {
if (arguments[0] === kInitialize) {
Expand All @@ -37,10 +39,18 @@ class Navigator {
this.#availableParallelism ??= getAvailableParallelism();
return this.#availableParallelism;
}

/**
* @return {string}
*/
get userAgent() {
return this.#userAgent;
}
}

ObjectDefineProperties(Navigator.prototype, {
hardwareConcurrency: kEnumerableProperty,
userAgent: kEnumerableProperty,
});

module.exports = {
Expand Down
2 changes: 2 additions & 0 deletions test/parallel/test-navigator.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ const is = {
is.number(+navigator.hardwareConcurrency, 'hardwareConcurrency');
is.number(navigator.hardwareConcurrency, 'hardwareConcurrency');
assert.ok(navigator.hardwareConcurrency > 0);
assert.strictEqual(typeof navigator.userAgent, 'string');
assert.match(navigator.userAgent, /^Node\.js\/\d+$/);

0 comments on commit 5a52c51

Please sign in to comment.