From 596125382421e2d945898bb99da430710afe7aa6 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 15 Jun 2024 18:23:35 +0100 Subject: [PATCH] src: remove `base64` from `process.versions` The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: https://github.com/nodejs/node/pull/52714 PR-URL: https://github.com/nodejs/node/pull/53442 Reviewed-By: Yagiz Nizipli Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Moshe Atlow Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Marco Ippolito --- src/base64_version.h | 6 ------ src/node_metadata.cc | 2 -- src/node_metadata.h | 3 +-- test/parallel/test-process-versions.js | 1 - 4 files changed, 1 insertion(+), 11 deletions(-) delete mode 100644 src/base64_version.h diff --git a/src/base64_version.h b/src/base64_version.h deleted file mode 100644 index ce3d7c03f8c979..00000000000000 --- a/src/base64_version.h +++ /dev/null @@ -1,6 +0,0 @@ -// This is an auto generated file, please do not edit. -// Refer to tools/dep_updaters/update-base64.sh -#ifndef SRC_BASE64_VERSION_H_ -#define SRC_BASE64_VERSION_H_ -#define BASE64_VERSION "0.5.2" -#endif // SRC_BASE64_VERSION_H_ diff --git a/src/node_metadata.cc b/src/node_metadata.cc index 14fb8ec9714001..a5992c4e11bbd3 100644 --- a/src/node_metadata.cc +++ b/src/node_metadata.cc @@ -2,7 +2,6 @@ #include "acorn_version.h" #include "ada.h" #include "ares.h" -#include "base64_version.h" #include "brotli/encode.h" #include "cjs_module_lexer_version.h" #include "llhttp.h" @@ -112,7 +111,6 @@ Metadata::Versions::Versions() { acorn = ACORN_VERSION; cjs_module_lexer = CJS_MODULE_LEXER_VERSION; - base64 = BASE64_VERSION; uvwasi = UVWASI_VERSION_STRING; #if HAVE_OPENSSL diff --git a/src/node_metadata.h b/src/node_metadata.h index 2eccd1d9dcdfd0..fcb1de273bf435 100644 --- a/src/node_metadata.h +++ b/src/node_metadata.h @@ -50,8 +50,7 @@ namespace node { V(simdutf) \ V(ada) \ NODE_VERSIONS_KEY_UNDICI(V) \ - V(cjs_module_lexer) \ - V(base64) + V(cjs_module_lexer) #if HAVE_OPENSSL #define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl) diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js index cf35aa67a42cdb..228bcfea2feee2 100644 --- a/test/parallel/test-process-versions.js +++ b/test/parallel/test-process-versions.js @@ -22,7 +22,6 @@ const expected_keys = [ 'simdutf', 'ada', 'cjs_module_lexer', - 'base64', ]; const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');