src: avoid unused variables and functions

PR-URL: #45542 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs · Nov 24, 2022 · 57bca94 · 57bca94
1 parent 649b31f
commit 57bca94
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -52,7 +52,9 @@ using v8_inspector::StringView;
 using v8_inspector::V8Inspector;
 using v8_inspector::V8InspectorClient;
 
+#ifdef __POSIX__
 static uv_sem_t start_io_thread_semaphore;
+#endif  // __POSIX__
 static uv_async_t start_io_thread_async;
 // This is just an additional check to make sure start_io_thread_async
 // is not accidentally re-used or used when uninitialized.

diff --git a/src/node_binding.cc b/src/node_binding.cc
@@ -222,7 +222,7 @@ static bool libc_may_be_musl() {
   has_cached_retval = true;
   return retval;
 }
-#else  // __linux__
+#elif defined(__POSIX__)
 static bool libc_may_be_musl() { return false; }
 #endif  // __linux__
 

diff --git a/src/node_credentials.cc b/src/node_credentials.cc
@@ -456,12 +456,12 @@ static void Initialize(Local<Object> target,
                        Local<Value> unused,
                        Local<Context> context,
                        void* priv) {
-  Environment* env = Environment::GetCurrent(context);
-  Isolate* isolate = env->isolate();
-
   SetMethod(context, target, "safeGetenv", SafeGetenv);
 
 #ifdef NODE_IMPLEMENTS_POSIX_CREDENTIALS
+  Environment* env = Environment::GetCurrent(context);
+  Isolate* isolate = env->isolate();
+
   READONLY_TRUE_PROPERTY(target, "implementsPosixCredentials");
   SetMethodNoSideEffect(context, target, "getuid", GetUid);
   SetMethodNoSideEffect(context, target, "geteuid", GetEUid);