Skip to content

Commit

Permalink
test: refactor test-dgram-membership
Browse files Browse the repository at this point in the history
* match full error message in assert.throws()
* wrapped function -> .bind()

PR-URL: #11388
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
Trott authored and italoacasas committed Feb 22, 2017
1 parent aea0d50 commit 5723087
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/parallel/test-dgram-membership.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ const assert = require('assert');
const dgram = require('dgram');
const multicastAddress = '224.0.0.114';

const setup = () => {
return dgram.createSocket({type: 'udp4', reuseAddr: true});
};
const setup = dgram.createSocket.bind(dgram, {type: 'udp4', reuseAddr: true});

// addMembership() on closed socket should throw
{
Expand Down Expand Up @@ -46,14 +44,16 @@ const setup = () => {
// addMembership() with invalid multicast address should throw
{
const socket = setup();
assert.throws(() => { socket.addMembership('256.256.256.256'); }, /EINVAL/);
assert.throws(() => { socket.addMembership('256.256.256.256'); },
/^Error: addMembership EINVAL$/);
socket.close();
}

// dropMembership() with invalid multicast address should throw
{
const socket = setup();
assert.throws(() => { socket.dropMembership('256.256.256.256'); }, /EINVAL/);
assert.throws(() => { socket.dropMembership('256.256.256.256'); },
/^Error: dropMembership EINVAL$/);
socket.close();
}

Expand Down

0 comments on commit 5723087

Please sign in to comment.