src: remove INT_MAX asserts in SecretKeyGenTraits

Now that CSPRNG() does not silently fail when the length exceeds INT_MAX anymore, there is no need for the two relevant assertions in SecretKeyGenTraits anymore. Refs: #47515 PR-URL: #48053 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
nodejs · May 30, 2023 · 45c3782 · 45c3782
1 parent bd311b6
commit 45c3782
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/crypto/crypto_keygen.cc b/src/crypto/crypto_keygen.cc
@@ -63,17 +63,13 @@ Maybe<bool> SecretKeyGenTraits::AdditionalConfig(
     SecretKeyGenConfig* params) {
   CHECK(args[*offset]->IsUint32());
   uint32_t bits = args[*offset].As<Uint32>()->Value();
-  static_assert(std::numeric_limits<decltype(bits)>::max() / CHAR_BIT <=
-                INT_MAX);
   params->length = bits / CHAR_BIT;
   *offset += 1;
   return Just(true);
 }
 
-KeyGenJobStatus SecretKeyGenTraits::DoKeyGen(
-    Environment* env,
-    SecretKeyGenConfig* params) {
-  CHECK_LE(params->length, INT_MAX);
+KeyGenJobStatus SecretKeyGenTraits::DoKeyGen(Environment* env,
+                                             SecretKeyGenConfig* params) {
   ByteSource::Builder bytes(params->length);
   if (CSPRNG(bytes.data<unsigned char>(), params->length).is_err())
     return KeyGenJobStatus::FAILED;