Skip to content

Commit

Permalink
deps: V8: re-add dummy Isolate::CheckMemoryPressure
Browse files Browse the repository at this point in the history
Undoes the ABI-breaking part of v8/v8@92a44876bd66aa.

Refs: v8/v8@92a4487

PR-URL: #34356
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
  • Loading branch information
addaleax authored and MylesBorins committed Jul 16, 2020
1 parent 2079fef commit 447b1e8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -9490,6 +9490,7 @@ class V8_EXPORT Isolate {

internal::Address* GetDataFromSnapshotOnce(size_t index);
void ReportExternalAllocationLimitReached();
void CheckMemoryPressure();
};

class V8_EXPORT StartupData {
Expand Down
3 changes: 3 additions & 0 deletions deps/v8/src/api/api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7987,6 +7987,9 @@ void Isolate::ReportExternalAllocationLimitReached() {
heap->ReportExternalMemoryPressure();
}

// Node v14.x ABI compat dummy.
void Isolate::CheckMemoryPressure() {}

HeapProfiler* Isolate::GetHeapProfiler() {
i::HeapProfiler* heap_profiler =
reinterpret_cast<i::Isolate*>(this)->heap_profiler();
Expand Down

0 comments on commit 447b1e8

Please sign in to comment.