stream: fix size function returned from QueuingStrategies

The `size` function returned from the `size` getter of `ByteLengthQueuingStrategy` or `CountQueuingStrategy` should not have a prototype property, nor be a constructor. Refs: https://streams.spec.whatwg.org/#blqs-size Refs: https://streams.spec.whatwg.org/#cqs-size Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #44867 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Oct 12, 2022 · 3fdf6cf · 3fdf6cf
1 parent 19a9099
commit 3fdf6cf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/lib/internal/webstreams/queuingstrategies.js b/lib/internal/webstreams/queuingstrategies.js
@@ -2,6 +2,7 @@
 
 const {
   ObjectDefineProperties,
+  ObjectDefineProperty,
   SymbolToStringTag,
 } = primordials;
 
@@ -47,11 +48,13 @@ const isCountQueuingStrategy =
  * }} QueuingStrategy
  */
 
-// eslint-disable-next-line func-name-matching,func-style
-const byteSizeFunction = function size(chunk) { return chunk.byteLength; };
-
-// eslint-disable-next-line func-name-matching,func-style
-const countSizeFunction = function size() { return 1; };
+const nameDescriptor = { __proto__: null, value: 'size' };
+const byteSizeFunction = ObjectDefineProperty(
+  (chunk) => chunk.byteLength,
+  'name',
+  nameDescriptor
+);
+const countSizeFunction = ObjectDefineProperty(() => 1, 'name', nameDescriptor);
 
 /**
  * @type {QueuingStrategy}

diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json
@@ -2,16 +2,6 @@
   "queuing-strategies-size-function-per-global.window.js": {
     "skip": "Browser-specific test"
   },
-  "queuing-strategies.any.js": {
-    "fail": {
-      "expected": [
-        "CountQueuingStrategy: size should not have a prototype property",
-        "ByteLengthQueuingStrategy: size should not have a prototype property",
-        "CountQueuingStrategy: size should not be a constructor",
-        "ByteLengthQueuingStrategy: size should not be a constructor"
-      ]
-    }
-  },
   "readable-streams/cross-realm-crash.window.js": {
     "skip": "Browser-specific test"
   },