test_runner: error on mocking an already mocked date

Fixes #55849 PR-URL: #55858 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Nov 27, 2024 · 363e7d5 · 363e7d5
1 parent 6858f7a
commit 363e7d5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/internal/test_runner/mock/mock_timers.js b/lib/internal/test_runner/mock/mock_timers.js
@@ -335,6 +335,9 @@ class MockTimers {
   #createDate() {
     kMock ??= Symbol('MockTimers');
     const NativeDateConstructor = this.#nativeDateDescriptor.value;
+    if (NativeDateConstructor.isMock) {
+      throw new ERR_INVALID_STATE('Date is already being mocked!');
+    }
     /**
      * Function to mock the Date constructor, treats cases as per ECMA-262
      * and returns a Date object with a mocked implementation

diff --git a/test/parallel/test-runner-mock-timers-date.js b/test/parallel/test-runner-mock-timers-date.js
@@ -117,4 +117,11 @@ describe('Mock Timers Date Test Suite', () => {
     assert.strictEqual(fn.mock.callCount(), 0);
     clearTimeout(id);
   });
+
+  it((t) => {
+    t.mock.timers.enable();
+    t.test('should throw when a already-mocked Date is mocked', (t2) => {
+      assert.throws(() => t2.mock.timers.enable(), { code: 'ERR_INVALID_STATE' });
+    });
+  });
 });