Skip to content

Commit

Permalink
build,win: mark x86 image as not SAFESEH
Browse files Browse the repository at this point in the history
Refs: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers

PR-URL: #25852
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
  • Loading branch information
refack authored and targos committed Mar 14, 2019
1 parent cec35a5 commit 2f477bd
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions node.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@
'-Werror=undefined-inline',
],
},
# Relevant only for x86.
# Refs: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers
'msvs_settings': {
'VCLinkerTool': {
'ImageHasSafeExceptionHandlers': 'false',
},
},
'conditions': [
[ 'clang==1', {
'cflags': [ '-Werror=undefined-inline', ]
Expand Down

0 comments on commit 2f477bd

Please sign in to comment.