test: add non-ASCII character embedding test

Add a test that verifies that non-ASCII characters may be used in the source code provided to `LoadEnvironment()`. PR-URL: #33972 Reviewed-By: James M Snell <[email protected]>
nodejs · Jun 27, 2020 · 2c568c8 · 2c568c8
1 parent 9760c6c
commit 2c568c8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/test/embedding/embedtest.cc b/test/embedding/embedtest.cc
@@ -93,6 +93,7 @@ int RunNodeInstance(MultiIsolatePlatform* platform,
         "const publicRequire ="
         "  require('module').createRequire(process.cwd() + '/');"
         "globalThis.require = publicRequire;"
+        "globalThis.embedVars = { nön_ascıı: '🏳️‍🌈' };"
         "require('vm').runInThisContext(process.argv[1]);");
 
     if (loadenv_ret.IsEmpty())  // There has been a JS exception.

diff --git a/test/embedding/test-embedding.js b/test/embedding/test-embedding.js
@@ -6,12 +6,23 @@ const child_process = require('child_process');
 const path = require('path');
 
 common.allowGlobals(global.require);
+common.allowGlobals(global.embedVars);
 let binary = `out/${common.buildType}/embedtest`;
 if (common.isWindows) {
   binary += '.exe';
 }
 binary = path.resolve(__dirname, '..', '..', binary);
 
+assert.strictEqual(
+  child_process.spawnSync(binary, ['console.log(42)'])
+    .stdout.toString().trim(),
+  '42');
+
+assert.strictEqual(
+  child_process.spawnSync(binary, ['console.log(embedVars.nön_ascıı)'])
+    .stdout.toString().trim(),
+  '🏳️‍🌈');
+
 assert.strictEqual(
   child_process.spawnSync(binary, ['console.log(42)'])
     .stdout.toString().trim(),