stream: throw TypeError when criteria fulfilled in getIterator

PR-URL: #53825 Fixes: #53819 Refs: #53819 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
nodejs · Aug 14, 2024 · 2a6a12e · 2a6a12e
1 parent af99ba3
commit 2a6a12e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/lib/internal/webstreams/util.js b/lib/internal/webstreams/util.js
@@ -18,6 +18,7 @@ const {
 
 const {
   codes: {
+    ERR_ARG_NOT_ITERABLE,
     ERR_INVALID_ARG_VALUE,
     ERR_INVALID_STATE,
     ERR_OPERATION_FAILED,
@@ -235,6 +236,11 @@ function getIterator(obj, kind = 'sync', method) {
       method = obj[SymbolAsyncIterator];
       if (method === undefined) {
         const syncMethod = obj[SymbolIterator];
+
+        if (syncMethod === undefined) {
+          throw new ERR_ARG_NOT_ITERABLE(obj);
+        }
+
         const syncIteratorRecord = getIterator(obj, 'sync', syncMethod);
         return createAsyncFromSyncIterator(syncIteratorRecord);
       }
@@ -243,6 +249,10 @@ function getIterator(obj, kind = 'sync', method) {
     }
   }
 
+  if (method === undefined) {
+    throw new ERR_ARG_NOT_ITERABLE(obj);
+  }
+
   const iterator = FunctionPrototypeCall(method, obj);
   if (typeof iterator !== 'object' || iterator === null) {
     throw new ERR_INVALID_STATE.TypeError('The iterator method must return an object');

diff --git a/test/parallel/test-webstream-readable-from.js b/test/parallel/test-webstream-readable-from.js
@@ -0,0 +1,9 @@
+'use strict';
+
+require('../common');
+const assert = require('node:assert');
+
+assert.throws(
+  () => ReadableStream.from({}),
+  { code: 'ERR_ARG_NOT_ITERABLE', name: 'TypeError' },
+);