From 2468e4ed3e7af1f32c8655bede19d9b1207325c7 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 9 Apr 2021 10:53:52 +0200 Subject: [PATCH] deps: V8: backport d59db06bf542 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: [weakrefs] Remove --no-harmony-weak-refs flag Bug: v8:8179 Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 Commit-Queue: Shu-yu Guo Reviewed-by: Shu-yu Guo Reviewed-by: Adam Klein Reviewed-by: Sathya Gunasekaran Cr-Commit-Position: refs/heads/master@{#73871} Refs: https://github.com/v8/v8/commit/d59db06bf5425ddb388fb5a576f4bf39bdcc0f8f PR-URL: https://github.com/nodejs/node/pull/38162 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell --- common.gypi | 2 +- deps/v8/src/flags/flag-definitions.h | 3 - deps/v8/src/heap/heap.cc | 3 - deps/v8/src/heap/mark-compact.cc | 3 - deps/v8/src/heap/weak-object-worklists.cc | 24 ++-- deps/v8/src/init/bootstrapper.cc | 122 ++++++++---------- deps/v8/test/cctest/test-js-weak-refs.cc | 19 --- .../fail/weak-refs-finalizationregistry1.js | 2 - .../fail/weak-refs-finalizationregistry1.out | 4 +- .../fail/weak-refs-finalizationregistry2.js | 2 - .../fail/weak-refs-finalizationregistry2.out | 4 +- .../test/message/fail/weak-refs-register1.js | 2 - .../test/message/fail/weak-refs-register1.out | 4 +- .../test/message/fail/weak-refs-register2.js | 2 - .../test/message/fail/weak-refs-register2.out | 4 +- .../test/message/fail/weak-refs-unregister.js | 2 - .../message/fail/weak-refs-unregister.out | 4 +- .../weakref-finalizationregistry-error.js | 2 +- .../monomorphic-named-load-with-no-map.js | 2 +- .../test/mjsunit/harmony/weakrefs/basics.js | 2 - .../weakrefs/cleanup-from-different-realm.js | 2 +- .../weakrefs/cleanup-is-not-a-microtask.js | 2 +- .../weakrefs/cleanup-on-detached-realm.js | 2 +- .../cleanup-proxy-from-different-realm.js | 2 +- .../test/mjsunit/harmony/weakrefs/cleanup.js | 2 +- .../harmony/weakrefs/cleanupsome-optional.js | 2 +- .../weakrefs/clearkeptobjects-on-quit.js | 2 - .../finalizationregistry-and-weakref.js | 2 +- ...nalizationregistry-independent-lifetime.js | 2 +- ...nalizationregistry-keeps-holdings-alive.js | 2 +- ...ry-scheduled-for-cleanup-multiple-times.js | 2 +- .../multiple-dirty-finalization-groups.js | 2 +- .../weakrefs/reentrant-gc-from-cleanup.js | 2 +- .../mjsunit/harmony/weakrefs/two-weakrefs.js | 2 +- .../harmony/weakrefs/undefined-holdings.js | 2 +- .../weakrefs/unregister-after-cleanup.js | 2 +- .../weakrefs/unregister-before-cleanup.js | 2 +- .../weakrefs/unregister-called-twice.js | 2 +- .../weakrefs/unregister-inside-cleanup.js | 2 +- .../weakrefs/unregister-inside-cleanup2.js | 2 +- .../weakrefs/unregister-inside-cleanup3.js | 2 +- .../harmony/weakrefs/unregister-many.js | 2 +- ...register-when-cleanup-already-scheduled.js | 2 +- .../harmony/weakrefs/weak-cell-basics.js | 2 +- .../weakrefs/weakref-creation-keeps-alive.js | 2 +- .../weakrefs/weakref-deref-keeps-alive.js | 2 +- .../execution/microtask-queue-unittest.cc | 1 - 47 files changed, 104 insertions(+), 161 deletions(-) diff --git a/common.gypi b/common.gypi index ba6b791a6ccf82..c19346bffad434 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.9', + 'v8_embedder_string': '-node.10', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/flags/flag-definitions.h b/deps/v8/src/flags/flag-definitions.h index 1aa25fa832ceb1..09f63e1344de82 100644 --- a/deps/v8/src/flags/flag-definitions.h +++ b/deps/v8/src/flags/flag-definitions.h @@ -246,8 +246,6 @@ DEFINE_BOOL(use_strict, false, "enforce strict mode") DEFINE_BOOL(harmony, false, "enable all completed harmony features") DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features") -// Enabling FinalizationRegistry#cleanupSome also enables weak refs -DEFINE_IMPLICATION(harmony_weak_refs_with_cleanup_some, harmony_weak_refs) // Update bootstrapper.cc whenever adding a new feature flag. @@ -286,7 +284,6 @@ DEFINE_IMPLICATION(harmony_weak_refs_with_cleanup_some, harmony_weak_refs) #define HARMONY_SHIPPING_BASE(V) \ V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \ V(harmony_atomics, "harmony atomics") \ - V(harmony_weak_refs, "harmony weak references") \ V(harmony_string_replaceall, "harmony String.prototype.replaceAll") \ V(harmony_logical_assignment, "harmony logical assignment") \ V(harmony_atomics_waitasync, "harmony Atomics.waitAsync") \ diff --git a/deps/v8/src/heap/heap.cc b/deps/v8/src/heap/heap.cc index 23b84296be18f1..21173cb0b48ff3 100644 --- a/deps/v8/src/heap/heap.cc +++ b/deps/v8/src/heap/heap.cc @@ -6228,8 +6228,6 @@ MaybeHandle Heap::DequeueDirtyJSFinalizationRegistry() { } void Heap::RemoveDirtyFinalizationRegistriesOnContext(NativeContext context) { - if (!FLAG_harmony_weak_refs) return; - DisallowGarbageCollection no_gc; Isolate* isolate = this->isolate(); @@ -6259,7 +6257,6 @@ void Heap::RemoveDirtyFinalizationRegistriesOnContext(NativeContext context) { } void Heap::KeepDuringJob(Handle target) { - DCHECK(FLAG_harmony_weak_refs); DCHECK(weak_refs_keep_during_job().IsUndefined() || weak_refs_keep_during_job().IsOrderedHashSet()); Handle table; diff --git a/deps/v8/src/heap/mark-compact.cc b/deps/v8/src/heap/mark-compact.cc index f46ca120d492b9..d4d03a7652fc03 100644 --- a/deps/v8/src/heap/mark-compact.cc +++ b/deps/v8/src/heap/mark-compact.cc @@ -2480,9 +2480,6 @@ void MarkCompactCollector::ClearWeakReferences() { } void MarkCompactCollector::ClearJSWeakRefs() { - if (!FLAG_harmony_weak_refs) { - return; - } JSWeakRef weak_ref; while (weak_objects_.js_weak_refs.Pop(kMainThreadTask, &weak_ref)) { HeapObject target = HeapObject::cast(weak_ref.target()); diff --git a/deps/v8/src/heap/weak-object-worklists.cc b/deps/v8/src/heap/weak-object-worklists.cc index 532739000febea..84df473076fdd7 100644 --- a/deps/v8/src/heap/weak-object-worklists.cc +++ b/deps/v8/src/heap/weak-object-worklists.cc @@ -115,19 +115,17 @@ void WeakObjects::UpdateWeakObjectsInCode( void WeakObjects::UpdateJSWeakRefs( WeakObjectWorklist& js_weak_refs) { - if (FLAG_harmony_weak_refs) { - js_weak_refs.Update( - [](JSWeakRef js_weak_ref_in, JSWeakRef* js_weak_ref_out) -> bool { - JSWeakRef forwarded = ForwardingAddress(js_weak_ref_in); - - if (!forwarded.is_null()) { - *js_weak_ref_out = forwarded; - return true; - } - - return false; - }); - } + js_weak_refs.Update( + [](JSWeakRef js_weak_ref_in, JSWeakRef* js_weak_ref_out) -> bool { + JSWeakRef forwarded = ForwardingAddress(js_weak_ref_in); + + if (!forwarded.is_null()) { + *js_weak_ref_out = forwarded; + return true; + } + + return false; + }); } void WeakObjects::UpdateWeakCells(WeakObjectWorklist& weak_cells) { diff --git a/deps/v8/src/init/bootstrapper.cc b/deps/v8/src/init/bootstrapper.cc index 37833e882326b1..46c3a1a66bae32 100644 --- a/deps/v8/src/init/bootstrapper.cc +++ b/deps/v8/src/init/bootstrapper.cc @@ -3854,6 +3854,61 @@ void Genesis::InitializeGlobal(Handle global_object, native_context()->set_bound_function_with_constructor_map(*map); } + { // -- F i n a l i z a t i o n R e g i s t r y + Handle finalization_registry_fun = InstallFunction( + isolate_, global, factory->FinalizationRegistry_string(), + JS_FINALIZATION_REGISTRY_TYPE, JSFinalizationRegistry::kHeaderSize, 0, + factory->the_hole_value(), Builtins::kFinalizationRegistryConstructor); + InstallWithIntrinsicDefaultProto( + isolate_, finalization_registry_fun, + Context::JS_FINALIZATION_REGISTRY_FUNCTION_INDEX); + + finalization_registry_fun->shared().DontAdaptArguments(); + finalization_registry_fun->shared().set_length(1); + + Handle finalization_registry_prototype( + JSObject::cast(finalization_registry_fun->instance_prototype()), + isolate()); + + InstallToStringTag(isolate_, finalization_registry_prototype, + factory->FinalizationRegistry_string()); + + SimpleInstallFunction(isolate_, finalization_registry_prototype, "register", + Builtins::kFinalizationRegistryRegister, 2, false); + + SimpleInstallFunction(isolate_, finalization_registry_prototype, + "unregister", + Builtins::kFinalizationRegistryUnregister, 1, false); + + // The cleanupSome function is created but not exposed, as it is used + // internally by InvokeFinalizationRegistryCleanupFromTask. + // + // It is exposed by FLAG_harmony_weak_refs_with_cleanup_some. + Handle cleanup_some_fun = SimpleCreateFunction( + isolate_, factory->InternalizeUtf8String("cleanupSome"), + Builtins::kFinalizationRegistryPrototypeCleanupSome, 0, false); + native_context()->set_finalization_registry_cleanup_some(*cleanup_some_fun); + } + + { // -- W e a k R e f + Handle weak_ref_fun = InstallFunction( + isolate_, global, "WeakRef", JS_WEAK_REF_TYPE, JSWeakRef::kHeaderSize, + 0, factory->the_hole_value(), Builtins::kWeakRefConstructor); + InstallWithIntrinsicDefaultProto(isolate_, weak_ref_fun, + Context::JS_WEAK_REF_FUNCTION_INDEX); + + weak_ref_fun->shared().DontAdaptArguments(); + weak_ref_fun->shared().set_length(1); + + Handle weak_ref_prototype( + JSObject::cast(weak_ref_fun->instance_prototype()), isolate()); + + InstallToStringTag(isolate_, weak_ref_prototype, factory->WeakRef_string()); + + SimpleInstallFunction(isolate_, weak_ref_prototype, "deref", + Builtins::kWeakRefDeref, 0, true); + } + { // --- sloppy arguments map Handle arguments_string = factory->Arguments_string(); Handle function = CreateFunctionForBuiltinWithPrototype( @@ -4351,75 +4406,8 @@ void Genesis::InitializeGlobal_harmony_atomics() { InstallToStringTag(isolate_, isolate()->atomics_object(), "Atomics"); } -void Genesis::InitializeGlobal_harmony_weak_refs() { - if (!FLAG_harmony_weak_refs) return; - - Factory* factory = isolate()->factory(); - Handle global(native_context()->global_object(), isolate()); - - { - // Create %FinalizationRegistry% - Handle finalization_registry_fun = InstallFunction( - isolate(), global, factory->FinalizationRegistry_string(), - JS_FINALIZATION_REGISTRY_TYPE, JSFinalizationRegistry::kHeaderSize, 0, - factory->the_hole_value(), Builtins::kFinalizationRegistryConstructor); - InstallWithIntrinsicDefaultProto( - isolate(), finalization_registry_fun, - Context::JS_FINALIZATION_REGISTRY_FUNCTION_INDEX); - - finalization_registry_fun->shared().DontAdaptArguments(); - finalization_registry_fun->shared().set_length(1); - - Handle finalization_registry_prototype( - JSObject::cast(finalization_registry_fun->instance_prototype()), - isolate()); - - InstallToStringTag(isolate(), finalization_registry_prototype, - factory->FinalizationRegistry_string()); - - SimpleInstallFunction(isolate(), finalization_registry_prototype, - "register", Builtins::kFinalizationRegistryRegister, - 2, false); - - SimpleInstallFunction(isolate(), finalization_registry_prototype, - "unregister", - Builtins::kFinalizationRegistryUnregister, 1, false); - - // The cleanupSome function is created but not exposed, as it is used - // internally by InvokeFinalizationRegistryCleanupFromTask. - // - // It is exposed by FLAG_harmony_weak_refs_with_cleanup_some. - Handle cleanup_some_fun = SimpleCreateFunction( - isolate(), factory->InternalizeUtf8String("cleanupSome"), - Builtins::kFinalizationRegistryPrototypeCleanupSome, 0, false); - native_context()->set_finalization_registry_cleanup_some(*cleanup_some_fun); - } - { - // Create %WeakRef% - Handle weak_ref_fun = InstallFunction( - isolate(), global, factory->WeakRef_string(), JS_WEAK_REF_TYPE, - JSWeakRef::kHeaderSize, 0, factory->the_hole_value(), - Builtins::kWeakRefConstructor); - InstallWithIntrinsicDefaultProto(isolate(), weak_ref_fun, - Context::JS_WEAK_REF_FUNCTION_INDEX); - - weak_ref_fun->shared().DontAdaptArguments(); - weak_ref_fun->shared().set_length(1); - - Handle weak_ref_prototype( - JSObject::cast(weak_ref_fun->instance_prototype()), isolate()); - - InstallToStringTag(isolate(), weak_ref_prototype, - factory->WeakRef_string()); - - SimpleInstallFunction(isolate(), weak_ref_prototype, "deref", - Builtins::kWeakRefDeref, 0, true); - } -} - void Genesis::InitializeGlobal_harmony_weak_refs_with_cleanup_some() { if (!FLAG_harmony_weak_refs_with_cleanup_some) return; - DCHECK(FLAG_harmony_weak_refs); Handle finalization_registry_fun = isolate()->js_finalization_registry_fun(); diff --git a/deps/v8/test/cctest/test-js-weak-refs.cc b/deps/v8/test/cctest/test-js-weak-refs.cc index 1291283515d557..7838e8ae25d037 100644 --- a/deps/v8/test/cctest/test-js-weak-refs.cc +++ b/deps/v8/test/cctest/test-js-weak-refs.cc @@ -209,7 +209,6 @@ Handle MakeWeakRefAndKeepDuringJob(Isolate* isolate) { } // namespace TEST(TestRegister) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -247,7 +246,6 @@ TEST(TestRegister) { } TEST(TestRegisterWithKey) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -300,7 +298,6 @@ TEST(TestRegisterWithKey) { } TEST(TestWeakCellNullify1) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -335,7 +332,6 @@ TEST(TestWeakCellNullify1) { } TEST(TestWeakCellNullify2) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -369,7 +365,6 @@ TEST(TestWeakCellNullify2) { } TEST(TestJSFinalizationRegistryPopClearedCellHoldings1) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -425,7 +420,6 @@ TEST(TestJSFinalizationRegistryPopClearedCellHoldings1) { TEST(TestJSFinalizationRegistryPopClearedCellHoldings2) { // Test that when all WeakCells for a key are popped, the key is removed from // the key map. - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -476,7 +470,6 @@ TEST(TestJSFinalizationRegistryPopClearedCellHoldings2) { } TEST(TestUnregisterActiveCells) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -529,7 +522,6 @@ TEST(TestUnregisterActiveCells) { } TEST(TestUnregisterActiveAndClearedCells) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -585,7 +577,6 @@ TEST(TestUnregisterActiveAndClearedCells) { } TEST(TestWeakCellUnregisterTwice) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -633,7 +624,6 @@ TEST(TestWeakCellUnregisterTwice) { } TEST(TestWeakCellUnregisterPopped) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -674,7 +664,6 @@ TEST(TestWeakCellUnregisterPopped) { } TEST(TestWeakCellUnregisterNonexistentKey) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -687,7 +676,6 @@ TEST(TestWeakCellUnregisterNonexistentKey) { } TEST(TestJSWeakRef) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; @@ -716,7 +704,6 @@ TEST(TestJSWeakRef) { } TEST(TestJSWeakRefIncrementalMarking) { - FLAG_harmony_weak_refs = true; if (!FLAG_incremental_marking) { return; } @@ -752,7 +739,6 @@ TEST(TestJSWeakRefIncrementalMarking) { } TEST(TestJSWeakRefKeepDuringJob) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; @@ -790,7 +776,6 @@ TEST(TestJSWeakRefKeepDuringJob) { } TEST(TestJSWeakRefKeepDuringJobIncrementalMarking) { - FLAG_harmony_weak_refs = true; if (!FLAG_incremental_marking) { return; } @@ -819,7 +804,6 @@ TEST(TestJSWeakRefKeepDuringJobIncrementalMarking) { } TEST(TestRemoveUnregisterToken) { - FLAG_harmony_weak_refs = true; CcTest::InitializeVM(); LocalContext context; Isolate* isolate = CcTest::i_isolate(); @@ -883,7 +867,6 @@ TEST(TestRemoveUnregisterToken) { } TEST(JSWeakRefScavengedInWorklist) { - FLAG_harmony_weak_refs = true; if (!FLAG_incremental_marking || FLAG_single_generation) { return; } @@ -928,7 +911,6 @@ TEST(JSWeakRefScavengedInWorklist) { } TEST(JSWeakRefTenuredInWorklist) { - FLAG_harmony_weak_refs = true; if (!FLAG_incremental_marking || FLAG_single_generation) { return; } @@ -976,7 +958,6 @@ TEST(JSWeakRefTenuredInWorklist) { } TEST(UnregisterTokenHeapVerifier) { - FLAG_harmony_weak_refs = true; if (!FLAG_incremental_marking) return; ManualGCScope manual_gc_scope; #ifdef VERIFY_HEAP diff --git a/deps/v8/test/message/fail/weak-refs-finalizationregistry1.js b/deps/v8/test/message/fail/weak-refs-finalizationregistry1.js index f23cfa3a51539d..f8b252b543aa3b 100644 --- a/deps/v8/test/message/fail/weak-refs-finalizationregistry1.js +++ b/deps/v8/test/message/fail/weak-refs-finalizationregistry1.js @@ -2,6 +2,4 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs - let fg = new FinalizationRegistry(); diff --git a/deps/v8/test/message/fail/weak-refs-finalizationregistry1.out b/deps/v8/test/message/fail/weak-refs-finalizationregistry1.out index 7775052c91d734..0844bc02b965c9 100644 --- a/deps/v8/test/message/fail/weak-refs-finalizationregistry1.out +++ b/deps/v8/test/message/fail/weak-refs-finalizationregistry1.out @@ -1,6 +1,6 @@ -*%(basename)s:7: TypeError: FinalizationRegistry: cleanup must be callable +*%(basename)s:*: TypeError: FinalizationRegistry: cleanup must be callable let fg = new FinalizationRegistry(); ^ TypeError: FinalizationRegistry: cleanup must be callable at new FinalizationRegistry () - at *%(basename)s:7:10 + at *%(basename)s:*:10 diff --git a/deps/v8/test/message/fail/weak-refs-finalizationregistry2.js b/deps/v8/test/message/fail/weak-refs-finalizationregistry2.js index 599bfc6d05ff93..2c540632871b1d 100644 --- a/deps/v8/test/message/fail/weak-refs-finalizationregistry2.js +++ b/deps/v8/test/message/fail/weak-refs-finalizationregistry2.js @@ -2,6 +2,4 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs - let fg = new FinalizationRegistry({}); diff --git a/deps/v8/test/message/fail/weak-refs-finalizationregistry2.out b/deps/v8/test/message/fail/weak-refs-finalizationregistry2.out index 278c3506bfe781..69125af984255e 100644 --- a/deps/v8/test/message/fail/weak-refs-finalizationregistry2.out +++ b/deps/v8/test/message/fail/weak-refs-finalizationregistry2.out @@ -1,6 +1,6 @@ -*%(basename)s:7: TypeError: FinalizationRegistry: cleanup must be callable +*%(basename)s:*: TypeError: FinalizationRegistry: cleanup must be callable let fg = new FinalizationRegistry({}); ^ TypeError: FinalizationRegistry: cleanup must be callable at new FinalizationRegistry () - at *%(basename)s:7:10 + at *%(basename)s:*:10 diff --git a/deps/v8/test/message/fail/weak-refs-register1.js b/deps/v8/test/message/fail/weak-refs-register1.js index 7110a25e6c6532..07d9c6c5b6f394 100644 --- a/deps/v8/test/message/fail/weak-refs-register1.js +++ b/deps/v8/test/message/fail/weak-refs-register1.js @@ -2,7 +2,5 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs - let fg = new FinalizationRegistry(() => {}); fg.register(1); diff --git a/deps/v8/test/message/fail/weak-refs-register1.out b/deps/v8/test/message/fail/weak-refs-register1.out index 6a9b23ecf8b56b..aa4cbc2fa22e1e 100644 --- a/deps/v8/test/message/fail/weak-refs-register1.out +++ b/deps/v8/test/message/fail/weak-refs-register1.out @@ -1,6 +1,6 @@ -*%(basename)s:8: TypeError: FinalizationRegistry.prototype.register: target must be an object +*%(basename)s:*: TypeError: FinalizationRegistry.prototype.register: target must be an object fg.register(1); ^ TypeError: FinalizationRegistry.prototype.register: target must be an object at FinalizationRegistry.register () - at *%(basename)s:8:4 + at *%(basename)s:*:4 diff --git a/deps/v8/test/message/fail/weak-refs-register2.js b/deps/v8/test/message/fail/weak-refs-register2.js index 31df8745852d82..b57da62095a4b7 100644 --- a/deps/v8/test/message/fail/weak-refs-register2.js +++ b/deps/v8/test/message/fail/weak-refs-register2.js @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs - let fg = new FinalizationRegistry(() => {}); let o = {}; fg.register(o, o); diff --git a/deps/v8/test/message/fail/weak-refs-register2.out b/deps/v8/test/message/fail/weak-refs-register2.out index 0f2c2f1ee2bd0e..04b1ff559f18e9 100644 --- a/deps/v8/test/message/fail/weak-refs-register2.out +++ b/deps/v8/test/message/fail/weak-refs-register2.out @@ -1,6 +1,6 @@ -*%(basename)s:9: TypeError: FinalizationRegistry.prototype.register: target and holdings must not be same +*%(basename)s:*: TypeError: FinalizationRegistry.prototype.register: target and holdings must not be same fg.register(o, o); ^ TypeError: FinalizationRegistry.prototype.register: target and holdings must not be same at FinalizationRegistry.register () - at *%(basename)s:9:4 + at *%(basename)s:*:4 diff --git a/deps/v8/test/message/fail/weak-refs-unregister.js b/deps/v8/test/message/fail/weak-refs-unregister.js index 0f41263cbafd53..7befe4a2f7c347 100644 --- a/deps/v8/test/message/fail/weak-refs-unregister.js +++ b/deps/v8/test/message/fail/weak-refs-unregister.js @@ -2,7 +2,5 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs - let fg = new FinalizationRegistry(() => {}); fg.unregister(1); diff --git a/deps/v8/test/message/fail/weak-refs-unregister.out b/deps/v8/test/message/fail/weak-refs-unregister.out index 766d04349fc38a..52945869838778 100644 --- a/deps/v8/test/message/fail/weak-refs-unregister.out +++ b/deps/v8/test/message/fail/weak-refs-unregister.out @@ -1,6 +1,6 @@ -*%(basename)s:8: TypeError: unregisterToken ('1') must be an object +*%(basename)s:*: TypeError: unregisterToken ('1') must be an object fg.unregister(1); ^ TypeError: unregisterToken ('1') must be an object at FinalizationRegistry.unregister () - at *%(basename)s:8:4 + at *%(basename)s:*:4 diff --git a/deps/v8/test/message/weakref-finalizationregistry-error.js b/deps/v8/test/message/weakref-finalizationregistry-error.js index e4c47fed0dcee8..42f5eb3bc0e1c9 100644 --- a/deps/v8/test/message/weakref-finalizationregistry-error.js +++ b/deps/v8/test/message/weakref-finalizationregistry-error.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking // Flags: --no-stress-opt // Since cleanup tasks are top-level tasks, errors thrown from them don't stop diff --git a/deps/v8/test/mjsunit/compiler/monomorphic-named-load-with-no-map.js b/deps/v8/test/mjsunit/compiler/monomorphic-named-load-with-no-map.js index 9341f8e8c91838..4150535462ff3e 100644 --- a/deps/v8/test/mjsunit/compiler/monomorphic-named-load-with-no-map.js +++ b/deps/v8/test/mjsunit/compiler/monomorphic-named-load-with-no-map.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // -// Flags: --allow-natives-syntax --harmony-weak-refs --expose-gc +// Flags: --allow-natives-syntax --expose-gc // Helper to convert setTimeout into an awaitable promise. function asyncTimeout(timeout) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/basics.js b/deps/v8/test/mjsunit/harmony/weakrefs/basics.js index 547a688c2ae346..f879df9a2a63b0 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/basics.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/basics.js @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs - (function TestConstructFinalizationRegistry() { let fg = new FinalizationRegistry(() => {}); assertEquals(fg.toString(), "[object FinalizationRegistry]"); diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-from-different-realm.js b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-from-different-realm.js index eac92486a0f1c6..960ab89487d393 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-from-different-realm.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-from-different-realm.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let r = Realm.create(); diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-is-not-a-microtask.js b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-is-not-a-microtask.js index 8b43618c711bd3..4e760144e6ad59 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-is-not-a-microtask.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-is-not-a-microtask.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking --allow-natives-syntax +// Flags: --expose-gc --noincremental-marking --allow-natives-syntax // This test asserts that the cleanup function call, scheduled by GC, is a // microtask and not a normal task. diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-on-detached-realm.js b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-on-detached-realm.js index 3513c8f211ae0c..11a9b3099d4c1e 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-on-detached-realm.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-on-detached-realm.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanedUp = false; let r = Realm.create(); diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-proxy-from-different-realm.js b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-proxy-from-different-realm.js index f2374efc885e95..a824bd9d852f6f 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-proxy-from-different-realm.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup-proxy-from-different-realm.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let r = Realm.create(); diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup.js b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup.js index ef60d3f1501a69..730312cba535a1 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/cleanup.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/cleanup.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_called = 0; let holdings_list = []; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/cleanupsome-optional.js b/deps/v8/test/mjsunit/harmony/weakrefs/cleanupsome-optional.js index 7476f2bd4eddf3..4cb24591722719 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/cleanupsome-optional.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/cleanupsome-optional.js @@ -5,7 +5,7 @@ // Flags: --harmony-weak-refs // FinalizationRegistry#cleanupSome is normative optional and has its own -// flag. Test that it's not present with only --harmony-weak-refs. +// flag. Test that it's not present. assertEquals(undefined, Object.getOwnPropertyDescriptor( FinalizationRegistry.prototype, "cleanupSome")); diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/clearkeptobjects-on-quit.js b/deps/v8/test/mjsunit/harmony/weakrefs/clearkeptobjects-on-quit.js index 6007f9c3608d3c..375c7f6d13f401 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/clearkeptobjects-on-quit.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/clearkeptobjects-on-quit.js @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs - // A newly created WeakRef is kept alive until the end of the next microtask // checkpoint. V8 asserts that the kept objects list is cleared at the end of // microtask checkpoints when the microtask policy is auto. Test that d8, which diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-and-weakref.js b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-and-weakref.js index 274e714994d616..a6cda82485923c 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-and-weakref.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-and-weakref.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_called = false; let cleanup = function(holdings) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-independent-lifetime.js b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-independent-lifetime.js index 72d2cae83ef4a2..4e0ab2af8ea7d4 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-independent-lifetime.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-independent-lifetime.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_called = false; function cleanup(holdings) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-keeps-holdings-alive.js b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-keeps-holdings-alive.js index f63d17ed7fe3c8..7a09273ca74128 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-keeps-holdings-alive.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-keeps-holdings-alive.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_called = false; let holdings_list = []; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-scheduled-for-cleanup-multiple-times.js b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-scheduled-for-cleanup-multiple-times.js index 3b3f3412a2039c..7db4d44a6a1cc9 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-scheduled-for-cleanup-multiple-times.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/finalizationregistry-scheduled-for-cleanup-multiple-times.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking // Flags: --no-stress-flush-bytecode let cleanup0_call_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/multiple-dirty-finalization-groups.js b/deps/v8/test/mjsunit/harmony/weakrefs/multiple-dirty-finalization-groups.js index 21b9ff709b7a68..533c3cb631bacf 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/multiple-dirty-finalization-groups.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/multiple-dirty-finalization-groups.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup_holdings_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/reentrant-gc-from-cleanup.js b/deps/v8/test/mjsunit/harmony/weakrefs/reentrant-gc-from-cleanup.js index 235a34a5921141..07e23f614f9bbd 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/reentrant-gc-from-cleanup.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/reentrant-gc-from-cleanup.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let call_count = 0; let reentrant_gc = function(holdings) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/two-weakrefs.js b/deps/v8/test/mjsunit/harmony/weakrefs/two-weakrefs.js index c17e7aa969d4fb..6cfc1a1aa7741f 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/two-weakrefs.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/two-weakrefs.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let o1 = {}; let o2 = {}; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/undefined-holdings.js b/deps/v8/test/mjsunit/harmony/weakrefs/undefined-holdings.js index 56d9b562a11d02..a45426e3f60ad3 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/undefined-holdings.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/undefined-holdings.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup_holdings_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-after-cleanup.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-after-cleanup.js index 400385d1931967..b23f396f38d1b8 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-after-cleanup.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-after-cleanup.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup_holdings_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-before-cleanup.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-before-cleanup.js index efa4df521703f0..aebcc6a746f95c 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-before-cleanup.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-before-cleanup.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking --noincremental-marking +// Flags: --expose-gc --noincremental-marking --noincremental-marking let cleanup_call_count = 0; let cleanup = function(holdings) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-called-twice.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-called-twice.js index ff48758c07d491..b3f425655eb2c4 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-called-twice.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-called-twice.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup = function(holdings) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup.js index e607a1ead5a262..903fb33a378c02 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup_holdings_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup2.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup2.js index e04b9f14859ce3..74799968445ca3 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup2.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup2.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup_holdings_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup3.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup3.js index e11fd3b8e938ce..ac1e0e2c41289a 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup3.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-inside-cleanup3.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup_holdings_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-many.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-many.js index 772078e1077d42..f9ff219d657247 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-many.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-many.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup_holdings_count = 0; diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-when-cleanup-already-scheduled.js b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-when-cleanup-already-scheduled.js index 3b3e488a82d108..05ba4f28d27d26 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/unregister-when-cleanup-already-scheduled.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/unregister-when-cleanup-already-scheduled.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_call_count = 0; let cleanup = function(holdings) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/weak-cell-basics.js b/deps/v8/test/mjsunit/harmony/weakrefs/weak-cell-basics.js index ee4b5ecb903ed8..3c8af1995b874d 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/weak-cell-basics.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/weak-cell-basics.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let cleanup_called = false; let cleanup = function(holdings_arg) { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/weakref-creation-keeps-alive.js b/deps/v8/test/mjsunit/harmony/weakrefs/weakref-creation-keeps-alive.js index 4c8641d8aa0ff2..78e8865ac02a60 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/weakref-creation-keeps-alive.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/weakref-creation-keeps-alive.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let wr; (function() { diff --git a/deps/v8/test/mjsunit/harmony/weakrefs/weakref-deref-keeps-alive.js b/deps/v8/test/mjsunit/harmony/weakrefs/weakref-deref-keeps-alive.js index eb02290dfdc64f..f7c05e88b85d62 100644 --- a/deps/v8/test/mjsunit/harmony/weakrefs/weakref-deref-keeps-alive.js +++ b/deps/v8/test/mjsunit/harmony/weakrefs/weakref-deref-keeps-alive.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --harmony-weak-refs --expose-gc --noincremental-marking +// Flags: --expose-gc --noincremental-marking let wr; let wr_control; // control WeakRef for testing what happens without deref diff --git a/deps/v8/test/unittests/execution/microtask-queue-unittest.cc b/deps/v8/test/unittests/execution/microtask-queue-unittest.cc index 7db92611793a47..84e29f25969558 100644 --- a/deps/v8/test/unittests/execution/microtask-queue-unittest.cc +++ b/deps/v8/test/unittests/execution/microtask-queue-unittest.cc @@ -41,7 +41,6 @@ class WithFinalizationRegistryMixin : public TMixin { static void SetUpTestCase() { CHECK_NULL(save_flags_); save_flags_ = new SaveFlags(); - FLAG_harmony_weak_refs = true; FLAG_expose_gc = true; FLAG_allow_natives_syntax = true; TMixin::SetUpTestCase();