From 22ccf2ba1f37ed2457d9017de85d424d20310ea6 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Wed, 15 Apr 2020 20:40:02 +0200 Subject: [PATCH] tools: decrease timeout in test.py This fixes the following crash on Windows for me. I don't know why this I only started to see this now, but anyway, the new timeout value is still longer than a week and a half. File "tools/test.py", line 1725, in sys.exit(Main()) File "tools/test.py", line 1701, in Main if RunTestCases(cases_to_run, options.progress, \ options.j, options.flaky_tests): File "tools/test.py", line 923, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 145, in Run thread.join(timeout=10000000) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1015, in join self._wait_for_tstate_lock(timeout=max(timeout, 0)) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1027, in _wait_for_tstate_lock elif lock.acquire(block, timeout): OverflowError: timeout value is too large PR-URL: https://github.com/nodejs/node/pull/32868 Reviewed-By: James M Snell Reviewed-By: Jeremiah Senkpiel Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Gireesh Punathil Reviewed-By: Ruben Bridgewater Reviewed-By: Zeyu Yang Reviewed-By: Bartosz Sosnowski --- tools/test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test.py b/tools/test.py index 5eb1fa767219ce..dde7c7b2f8e466 100755 --- a/tools/test.py +++ b/tools/test.py @@ -142,7 +142,7 @@ def Run(self, tasks): # Wait for the remaining threads for thread in threads: # Use a timeout so that signals (ctrl-c) will be processed. - thread.join(timeout=10000000) + thread.join(timeout=1000000) except (KeyboardInterrupt, SystemExit): self.shutdown_event.set() except Exception: