test: fix assertions in test-snapshot-dns-lookup*

Due to the unfortunate nature of JavaScript, the extraneous arguments are silently ignored. In this case, the assertion trivially passes regardless of the given regular expressions. Refs: #44633 PR-URL: #46618 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Feb 20, 2023 · 2239e24 · 2239e24
1 parent 6a8b04d
commit 2239e24
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/test/internet/test-snapshot-dns-lookup.js b/test/internet/test-snapshot-dns-lookup.js
@@ -19,8 +19,8 @@ const env = {
 
 tmpdir.refresh();
 function checkOutput(stderr, stdout) {
-  assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
-  assert(stdout.match(stdout, /family: 4/));
+  assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
+  assert.match(stdout, /family: 4/);
   assert.strictEqual(stdout.trim().split('\n').length, 2);
 }
 {

diff --git a/test/parallel/test-snapshot-dns-lookup-localhost-promise.js b/test/parallel/test-snapshot-dns-lookup-localhost-promise.js
@@ -19,8 +19,8 @@ function checkOutput(stderr, stdout) {
   // We allow failures as it's not always possible to resolve localhost.
   // Functional tests are done in test/internet instead.
   if (!stderr.startsWith('error:')) {
-    assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
-    assert(stdout.match(stdout, /family: 4/));
+    assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
+    assert.match(stdout, /family: 4/);
     assert.strictEqual(stdout.trim().split('\n').length, 2);
   }
 }

diff --git a/test/parallel/test-snapshot-dns-lookup-localhost.js b/test/parallel/test-snapshot-dns-lookup-localhost.js
@@ -19,8 +19,8 @@ function checkOutput(stderr, stdout) {
   // We allow failures as it's not always possible to resolve localhost.
   // Functional tests are done in test/internet instead.
   if (!stderr.startsWith('error:')) {
-    assert(stdout.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/));
-    assert(stdout.match(stdout, /family: 4/));
+    assert.match(stdout, /address: "\d+\.\d+\.\d+\.\d+"/);
+    assert.match(stdout, /family: 4/);
     assert.strictEqual(stdout.trim().split('\n').length, 2);
   }
 }