Skip to content

Commit

Permalink
test: improve code coverage for i18n
Browse files Browse the repository at this point in the history
Coverage report for src/node_i18n.cc shows that the
Has() method is not covered. This test adds coverage
for that method.

PR-URL: #25428
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
mhdawson authored and addaleax committed Jan 23, 2019

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
1 parent bb7f71a commit 2112b70
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions test/parallel/test-icu-punycode.js
Original file line number Diff line number Diff line change
@@ -9,6 +9,12 @@ const { internalBinding } = require('internal/test/binding');
const icu = internalBinding('icu');
const assert = require('assert');

// test hasConverter method
assert(icu.hasConverter('utf-8'),
'hasConverter should report coverter exists for utf-8');
assert(!icu.hasConverter('x'),
'hasConverter should report coverter does not exist for x');

const tests = require('../fixtures/url-idna.js');
const fixtures = require('../common/fixtures');
const wptToASCIITests = require(

0 comments on commit 2112b70

Please sign in to comment.