src: use MaybeLocal.ToLocal instead of IsEmpty

This commit suggest using MaybeLocal.ToLocal and passing in the Local<Function> fn. The motivation for doing this is that the following MaybeLocal.ToLocalChecked call can then be avoided. PR-URL: #33554 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jun 18, 2020 · 20d54f6 · 20d54f6
1 parent 5438611
commit 20d54f6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/api/environment.cc b/src/api/environment.cc
@@ -634,10 +634,10 @@ bool InitializePrimordials(Local<Context> context) {
     MaybeLocal<Function> maybe_fn =
         native_module::NativeModuleEnv::LookupAndCompile(
             context, *module, &parameters, nullptr);
-    if (maybe_fn.IsEmpty()) {
+    Local<Function> fn;
+    if (!maybe_fn.ToLocal(&fn)) {
       return false;
     }
-    Local<Function> fn = maybe_fn.ToLocalChecked();
     MaybeLocal<Value> result =
         fn->Call(context, Undefined(isolate), arraysize(arguments), arguments);
     // Execution failed during context creation.