fs: remove extraneous assignments in rmdir()

validateRmOptions() doesn't return a value, so this commit removes the assignment. The options passed to validateRmdirOptions() are not used again after validation, so this commit removes the assignment. PR-URL: #35567 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
nodejs · Oct 14, 2020 · 1ad9aca · 1ad9aca
1 parent 1fadcf2
commit 1ad9aca
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -859,20 +859,16 @@ function rmdir(path, options, callback) {
   path = pathModule.toNamespacedPath(getValidatedPath(path));
 
   if (options && options.recursive) {
-    options = validateRmOptions(
-      path,
-      { ...options, force: true },
-      (err, options) => {
-        if (err) {
-          return callback(err);
-        }
-
-        lazyLoadRimraf();
-        return rimraf(path, options, callback);
-      });
+    validateRmOptions(path, { ...options, force: true }, (err, options) => {
+      if (err) {
+        return callback(err);
+      }
 
+      lazyLoadRimraf();
+      return rimraf(path, options, callback);
+    });
   } else {
-    options = validateRmdirOptions(options);
+    validateRmdirOptions(options);
     const req = new FSReqCallback();
     req.oncomplete = callback;
     return binding.rmdir(path, req);