From 1a2c80957bb7dfe6ad373a45218bdefbc16e6ebd Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Fri, 19 Nov 2021 04:17:57 -0500 Subject: [PATCH] doc: add pref to using draft PR versus WIP label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - add to the contribution guide that we prefer that people use draft PRs instead of the WIP label. Signed-off-by: Michael Dawson PR-URL: https://github.com/nodejs/node/pull/40824 Reviewed-By: Tobias Nießen Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- doc/guides/contributing/pull-requests.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index f7c246f4dc1cf1..0028969fa87b4b 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -271,6 +271,11 @@ details, but feel free to skip parts if you're not sure what to put. Once opened, pull requests are usually reviewed within a few days. +To get feedback on your proposed change even though it is not ready +to land, use the `Convert to draft` option in the GitHub UI. +Do not use the `wip` label as it might not prevent the PR +from landing before you are ready. + ### Step 9: Discuss and update You will probably get feedback or requests for changes to your pull request.