From 1a2b3eb3a4744c2a802c3b9b7e0752e63b47099b Mon Sep 17 00:00:00 2001 From: Robert Nagy Date: Thu, 23 Apr 2020 21:36:32 +0200 Subject: [PATCH] stream: fix broken pipeline test An unfortunate overlap between two PR that by themselves pass CI but together pass a test. https://github.com/nodejs/node/pull/32967 changes so that pipeline does not wait for 'close'. https://github.com/nodejs/node/pull/32968 changed so that all streams are not destroyed. Which made one test fail when expected the stream to be destroyed during pipeline callback. PR-URL: https://github.com/nodejs/node/pull/33030 Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- test/parallel/test-stream-pipeline.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-stream-pipeline.js b/test/parallel/test-stream-pipeline.js index 453ac30b3f4d64..203a32b5cd74a1 100644 --- a/test/parallel/test-stream-pipeline.js +++ b/test/parallel/test-stream-pipeline.js @@ -982,7 +982,7 @@ const net = require('net'); dst.readable = false; pipeline(src, dst, common.mustCall((err) => { assert(!err); - assert.strictEqual(dst.destroyed, true); + assert.strictEqual(dst.destroyed, false); })); src.end(); }