lib: do not lazy load EOL in blob

This addresses a comment by loading the EOL from the constants file. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41004 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Dec 13, 2021 · 1572db3 · 1572db3
1 parent da87413
commit 1572db3
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/lib/internal/blob.js b/lib/internal/blob.js
@@ -75,7 +75,6 @@ const disallowedTypeCharacters = /[^\u{0020}-\u{007E}]/u;
 
 let ReadableStream;
 let URL;
-let EOL;
 
 const enc = new TextEncoder();
 
@@ -94,13 +93,7 @@ function lazyReadableStream(options) {
   return new ReadableStream(options);
 }
 
-// TODO(@jasnell): This is annoying but this has to be lazy because
-// requiring the 'os' module too early causes building Node.js to
-// fail with an unknown reference failure.
-function lazyEOL() {
-  EOL ??= require('os').EOL;
-  return EOL;
-}
+const { EOL } = require('internal/constants');
 
 function isBlob(object) {
   return object?.[kHandle] !== undefined;
@@ -115,7 +108,7 @@ function getSource(source, endings) {
   } else if (!isArrayBufferView(source)) {
     source = `${source}`;
     if (endings === 'native')
-      source = RegExpPrototypeSymbolReplace(/\n|\r\n/g, source, lazyEOL());
+      source = RegExpPrototypeSymbolReplace(/\n|\r\n/g, source, EOL);
     source = enc.encode(source);
   }