From 1553e21007c5988830ad2b2cda77f0808ee68333 Mon Sep 17 00:00:00 2001 From: Franziska Hinkelmann Date: Fri, 7 Sep 2018 19:46:30 -0400 Subject: [PATCH] doc: clarify assigning issues to the TSC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/22759 Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Gireesh Punathil Reviewed-By: Anatoli Papirovski Reviewed-By: Trivikram Kamat Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Michael Dawson Reviewed-By: Sakthipriyan Vairamani --- COLLABORATOR_GUIDE.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 70f4b1a87ca16f..513faa46c8ab34 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -486,9 +486,8 @@ level. ### Involving the TSC -Collaborators may opt to elevate pull requests or issues to the [TSC][] for -discussion by assigning the `tsc-review` label or @-mentioning the -`@nodejs/tsc` GitHub team. This should be done where a pull request: +Collaborators may opt to elevate pull requests or issues to the [TSC][]. +This should be done where a pull request: - is labeled `semver-major`, or - has a significant impact on the codebase, or @@ -496,6 +495,11 @@ discussion by assigning the `tsc-review` label or @-mentioning the - has failed to reach consensus amongst the Collaborators who are actively participating in the discussion. +Assign the `tsc-review` label or @-mention the +`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. +Do not use the GitHub UI on the right hand side to assign to +`@nodejs/tsc` or request a review from `@nodejs/tsc`. + The TSC should serve as the final arbiter where required. ## Landing Pull Requests