From 153f5eda0e343bd250843b3804a9748dc4b26f83 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Mon, 1 Jun 2020 14:52:58 -0400 Subject: [PATCH] build: fix compiling addons with older versions of Node.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: https://github.com/nodejs/node/pull/33688 Refs: https://github.com/nodejs/node/pull/30463 Reviewed-By: Luigi Pinca Reviewed-By: Michaël Zasso Reviewed-By: Ben Noordhuis Reviewed-By: Matteo Collina Signed-off-by: Richard Lau --- common.gypi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/common.gypi b/common.gypi index c939d787e9f65b..e2e7eaf00db3db 100644 --- a/common.gypi +++ b/common.gypi @@ -57,6 +57,12 @@ # https://github.com/nodejs/node/pull/22920/files#r222779926 'v8_enable_handle_zapping': 0, + # Disable pointer compression. Can be enabled at build time via configure + # options but default values are required here as this file is also used by + # node-gyp to build addons. + 'v8_enable_pointer_compression%': 0, + 'v8_enable_31bit_smis_on_64bit_arch%': 0, + # Disable V8 untrusted code mitigations. # See https://github.com/v8/v8/wiki/Untrusted-code-mitigations 'v8_untrusted_code_mitigations': 0,