build: fix make invocation in tools.yml

Be in the correct directory for `make lint-md-rollup`. PR-URL: #40890 Refs: https://github.com/nodejs/node/runs/4270533399?check_suite_focus=true Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Nov 26, 2021 · 1482c44 · 1482c44
1 parent 4288c6a
commit 1482c44
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml
@@ -35,10 +35,17 @@ jobs:
           - id: "lint-md dependencies"
             run: |
               cd tools/lint-md
-              NEW_VERSION=$(npm outdated --omit=dev --parseable | cut -d: -f4 | xargs)
+              npm ci
+              NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
               if [ "$NEW_VERSION" != "" ]; then
                 echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
-                rm -rf package-lock.json node_modules && npm install --ignore-scripts
+                rm -rf package-lock.json node_modules
+                # Include $NEW_VERSION to explicitly update the package.json
+                # entry for the dependency and also so that semver-major updates
+                # are not skipped.
+                npm install --ignore-scripts $NEW_VERSION
+                npm install --ignore-scripts
+                cd ../..
                 make lint-md-rollup
               fi
     steps: