From 139552ea6688ff5be29b34a3df5d33ed863e9445 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Thu, 26 Oct 2017 09:08:38 -0700 Subject: [PATCH] doc: slightly relax 50 character rule MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Allow commit message first line to exceed 50 chars if necessary PR-URL: https://github.com/nodejs/node/pull/16523 Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Evan Lucas Reviewed-By: Anatoli Papirovski Reviewed-By: Refael Ackermann Reviewed-By: Gibson Fahnestock Reviewed-By: Joyee Cheung --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1c6de8d25498fe..99278a843af683 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -309,8 +309,8 @@ notes about [commit squashing](#commit-squashing)). A good commit message should describe what changed and why. 1. The first line should: - - contain a short description of the change - - be 50 characters or less + - contain a short description of the change (preferably 50 characters or less, + and no more than 72 characters) - be entirely in lowercase with the exception of proper nouns, acronyms, and the words that refer to code, like function/variable names - be prefixed with the name of the changed subsystem and start with an