cluster: replace forEach with for-of loop

Signed-off-by: Jérôme Benoit <[email protected]> PR-URL: #50317 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · May 12, 2024 · 11e9789 · 11e9789
1 parent c676e52
commit 11e9789
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/internal/cluster/child.js b/lib/internal/cluster/child.js
@@ -270,14 +270,14 @@ function _disconnect(primaryInitiated) {
     }
   }
 
-  handles.forEach((handle) => {
+  for (const handle of handles.values()) {
     waitingCount++;
 
     if (handle[owner_symbol])
       handle[owner_symbol].close(checkWaitingCount);
     else
       handle.close(checkWaitingCount);
-  });
+  }
 
   handles.clear();
   checkWaitingCount();

diff --git a/lib/internal/cluster/primary.js b/lib/internal/cluster/primary.js
@@ -152,10 +152,10 @@ function removeWorker(worker) {
 function removeHandlesForWorker(worker) {
   assert(worker);
 
-  handles.forEach((handle, key) => {
+  for (const { 0: key, 1: handle } of handles) {
     if (handle.remove(worker))
       handles.delete(key);
-  });
+  }
 }
 
 cluster.fork = function(env) {