fs: fix fs.promises.realpath for long paths on Windows

Unlike other fs functions that work with paths, realpath isn't using pathModule.toNamespacedPath prior to calling libuv function. This is causing issues on windows. Windows long path test is also improved to cover the mentioned issue. Fixes: #51031 PR-URL: #51032 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jan 2, 2024 · 091098f · 091098f
1 parent 652af45
commit 091098f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -1160,7 +1160,7 @@ async function realpath(path, options) {
   options = getOptions(options);
   path = getValidatedPath(path);
   return await PromisePrototypeThen(
-    binding.realpath(path, options.encoding, kUsePromises),
+    binding.realpath(pathModule.toNamespacedPath(path), options.encoding, kUsePromises),
     undefined,
     handleErrorFromBinding,
   );

diff --git a/test/parallel/test-fs-long-path.js b/test/parallel/test-fs-long-path.js
@@ -46,4 +46,7 @@ fs.writeFile(fullPath, 'ok', common.mustSucceed(() => {
 
   // Tests https://github.com/nodejs/node/issues/39721
   fs.realpath.native(fullPath, common.mustSucceed());
+
+  // Tests https://github.com/nodejs/node/issues/51031
+  fs.promises.realpath(fullPath).then(common.mustCall(), common.mustNotCall());
 }));