events: improve Event compatibility

This fixes `Event` constructor to improve `Event Web API` compatibility. The test added was written by referring to `wpt@dom/events/Event-constructors.any.js`. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #43461 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 12, 2022 · 061ed0e · 061ed0e
1 parent 2e181f6
commit 061ed0e
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 5 deletions.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -95,13 +95,11 @@ class Event {
    *   composed?: boolean,
    * }} [options]
    */
-  constructor(type, options = null) {
+  constructor(type, options = kEmptyObject) {
     if (arguments.length === 0)
       throw new ERR_MISSING_ARGS('type');
-    validateObject(options, 'options', {
-      allowArray: true, allowFunction: true, nullable: true,
-    });
-    const { cancelable, bubbles, composed } = { ...options };
+    validateObject(options, 'options');
+    const { bubbles, cancelable, composed } = options;
     this.#cancelable = !!cancelable;
     this.#bubbles = !!bubbles;
     this.#composed = !!composed;

diff --git a/test/parallel/test-whatwg-events-event-constructors.js b/test/parallel/test-whatwg-events-event-constructors.js
@@ -0,0 +1,29 @@
+'use strict';
+
+require('../common');
+const { test, assert_equals, assert_array_equals } =
+  require('../common/wpt').harness;
+
+// Source: https://github.com/web-platform-tests/wpt/blob/6cef1d2087d6a07d7cc6cee8cf207eec92e27c5f/dom/events/Event-constructors.any.js#L91-L112
+test(function() {
+  const called = [];
+  const ev = new Event('Xx', {
+    get cancelable() {
+      called.push('cancelable');
+      return false;
+    },
+    get bubbles() {
+      called.push('bubbles');
+      return true;
+    },
+    get sweet() {
+      called.push('sweet');
+      return 'x';
+    },
+  });
+  assert_array_equals(called, ['bubbles', 'cancelable']);
+  assert_equals(ev.type, 'Xx');
+  assert_equals(ev.bubbles, true);
+  assert_equals(ev.cancelable, false);
+  assert_equals(ev.sweet, undefined);
+});