lib: replace string prototype usage with alternatives

PR-URL: #52440 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Apr 29, 2024 · 014bf01 · 014bf01
1 parent 95c515e
commit 014bf01
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/lib/internal/options.js b/lib/internal/options.js
@@ -5,6 +5,10 @@ const {
   getEmbedderOptions: getEmbedderOptionsFromBinding,
 } = internalBinding('options');
 
+const {
+  StringPrototypeSlice,
+} = primordials;
+
 let warnOnAllowUnauthorized = true;
 
 let optionsMap;
@@ -43,8 +47,15 @@ function refreshOptions() {
 
 function getOptionValue(optionName) {
   const options = getCLIOptionsFromBinding();
-  if (optionName.startsWith('--no-')) {
-    const option = options.get('--' + optionName.slice(5));
+  if (
+    optionName.length > 5 &&
+    optionName[0] === '-' &&
+    optionName[1] === '-' &&
+    optionName[2] === 'n' &&
+    optionName[3] === 'o' &&
+    optionName[4] === '-'
+  ) {
+    const option = options.get('--' + StringPrototypeSlice(optionName, 5));
     return option && !option.value;
   }
   return options.get(optionName)?.value;