No Windows builds since 2020.05.28

[vsemozhetbyt]

https://nodejs.org/download/v8-canary/v15.0.0-v8-canary2020053077f9337a58/
https://nodejs.org/download/v8-canary/v15.0.0-v8-canary202005311fd149cdf5/
https://nodejs.org/download/v8-canary/v15.0.0-v8-canary20200601bbef71d2b9/
https://nodejs.org/download/v8-canary/v15.0.0-v8-canary202006025eea8ef984/

[bzoz]

Maybe it is because the build issues in nodejs/node#33579?

[vsemozhetbyt]

FWIW, the recent nightly builds have Windows binaries:

https://nodejs.org/download/nightly/v15.0.0-nightly202005296a1df3b5af/
https://nodejs.org/download/nightly/v15.0.0-nightly20200530d79c330186/
https://nodejs.org/download/nightly/v15.0.0-nightly202005312935f72ae1/

[gengjiawen]

Maybe it is because the build issues in nodejs/node#33579?

Is it the node-v8 daily windows build using vs2017 ? @targos @ryzokuken

[gengjiawen]

Looks like windows build is broken: https://github.com/nodejs/node-v8/runs/726470134.

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1757,1): error C2027: use of undefined type 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\execution\off-thread-isolate.h(20): message : see declaration of 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1756): message : while compiling class template member function 'void std::default_delete<v8::internal::OffThreadTransferHandleStorage>::operator ()(_Ty *) noexcept const' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
          with
          [
              _Ty=v8::internal::OffThreadTransferHandleStorage
          ]

[gengjiawen]

Looks like windows build is broken: nodejs/node-v8/runs/726470134.

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1757,1): error C2027: use of undefined type 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\execution\off-thread-isolate.h(20): message : see declaration of 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1756): message : while compiling class template member function 'void std::default_delete<v8::internal::OffThreadTransferHandleStorage>::operator ()(_Ty *) noexcept const' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
          with
          [
              _Ty=v8::internal::OffThreadTransferHandleStorage
          ]

Not sure related to this:
nodejs/node#33685
v8/v8@e87972b#commitcomment-39582496.

[gengjiawen]

Possible fix: #159

[gengjiawen]

Possible fix: #159

Looks like build passed on github action.

Upstream patch: https://chromium-review.googlesource.com/c/v8/v8/+/2226121.

[gengjiawen]

Looks like fixed: https://nodejs.org/download/v8-canary/v15.0.0-v8-canary20200603908772e6f4/