-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade release please action from v2 to v4 #2982
Conversation
I can set the I did something similar in nw-builder and created a release from the PR as target branch. |
@DeeDeeG Your review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me overall.
I had only a couple of minor suggestions for changes, one of which is only a code style suggestion, but the other should keep our tag names consistent with what they have been since before release-please-action@v4
.
For context: I am doing this review after looking over this PR author's other PR doing similar: https://github.com/nwutils/nw-builder/pull/1032/files ...And the implementation they said they looked at for reference: https://github.com/mdn/yari/commits/main/release-please-config.json... And the official config file schema for the latest release-please
version: https://github.com/googleapis/release-please/blob/3569f158158e2bd096a94c145bdb1a7f455829f0/schemas/config.json
This seems to be a valid configuration that should work with release-please-action@v4
.
Thank you @ayushmanchhabra for doing this!
Co-authored-by: DeeDeeG <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Co-authored-by: DeeDeeG <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approve after indentation change. (Thanks!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think last-release-sha
is necessary since Release Please should pick up the latest release automatically. I am going to merge this without that change and see if the Release PR looks correct. If not I will make another PR adding this back in.
* chore(release-please-action): upgrade from v2 to v4 * chore(ci): remove target branch * chore(release-please): disable `include-component-in-tag` Co-authored-by: DeeDeeG <[email protected]> * chore(release-please): format JSON properties per line Co-authored-by: DeeDeeG <[email protected]> * Remove last release sha --------- Co-authored-by: DeeDeeG <[email protected]> Co-authored-by: Luke Karrys <[email protected]>
Checklist
npm install && npm run lint && npm test
passesDescription of change
Upgrade Release Please action from v2 to v4.
Fixes: #2971