Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled GitHub CI rerun after success is treated as failure #633

Open
LiviaMedeiros opened this issue May 15, 2022 · 0 comments
Open

Cancelled GitHub CI rerun after success is treated as failure #633

LiviaMedeiros opened this issue May 15, 2022 · 0 comments

Comments

@LiviaMedeiros
Copy link
Contributor

PR: nodejs/node#43085
Action rerun attempt: https://github.com/nodejs/node/actions/runs/2320332585/attempts/7
git-node land output: nodejs/node#43085 (comment)

At the moment of landing, the latest run of that action was cancelled, there were 5 prior successful runs, and GitHub UI reported everything as green.
However, ncu treated it as Last GitHub CI failed error, which is either wrong (not sure if easily fixable, as it requires failproof checking previous attempts) or confusing (Last GitHub CI cancelled might be a better error message).

Details: in PRChecker.checkGitHubCI(), commit.checkSuites.nodes[2] for this case was

  {
    app: { slug: 'github-actions' },
    conclusion: 'CANCELLED',
    status: 'COMPLETED'
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant