Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS 2013 Support #58

Closed
mateodelnorte opened this issue Jun 12, 2017 · 9 comments
Closed

VS 2013 Support #58

mateodelnorte opened this issue Jun 12, 2017 · 9 comments

Comments

@mateodelnorte
Copy link

Hi all. This issue is for VS 2013 support.

I've got a client who has a number of 3rd party libraries that only compile under VS 2013. This is a continuation of #56. There are some additional notes there.

Here's a gist of the build errors I get when building with --msvs_version=2013: https://gist.github.com/mateodelnorte/7ea8c72e3b2b664ba37da7a0e6ed6dd8.

Thx
@mateodelnorte
Copy link
Author

Looks like this issue quickly pooled some +1's. Any ideas on ETA of a PR landing? Trying to prioritize whether I should wait for this, or chug ahead using nan.

@nschonni
Copy link
Member

I'm not sure if node-gyp still supports 2013 https://github.com/nodejs/node-gyp#option-2

@mateodelnorte
Copy link
Author

I'd be very surprised if that was the case: https://github.com/nodejs/node-gyp/blob/f6eab1f9e4b160b60b2736bb01a09c83785ba979/gyp/pylib/gyp/MSVSVersion.py#L228-L255

Those are just default instructions for getting running.

@kfarnung
Copy link
Contributor

@mateodelnorte I'm taking a look this, but I don't have a timeline for support. I'll let you know when I have some further information.

@mateodelnorte
Copy link
Author

awesome @kfarnung. thanks!

@kfarnung
Copy link
Contributor

@mateodelnorte I think we're pretty close now, take a look at PR #65.

@mateodelnorte
Copy link
Author

Fantastic! Thanks @kfarnung

@jasongin
Copy link
Member

Merged as 617dbb6, and published to npm as [email protected]

mhdawson pushed a commit that referenced this issue Nov 10, 2019
@KevinEady @mhdawson
tsfn: support direct calls to underlying napi_tsfn
df75e08 
support direct calls to underlying napi_tsfn

Fixes: #556
PR-URL: #58
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
@vijaykumbhani
Copy link

Hi @jasongin

as per comments, you have fixed the issue at 617dbb6.
can you please say, will this fix include on node-addon-api 3.1.0 later version?
if yes then what will be the approx date of a new version of node-addon-api 3.1.0
Waiting for a reply from your end

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
tsfn: support direct calls to underlying napi_tsfn
776d311 
support direct calls to underlying napi_tsfn

Fixes: nodejs/node-addon-api#556
PR-URL: nodejs/node-addon-api#58
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
tsfn: support direct calls to underlying napi_tsfn
216d683 
support direct calls to underlying napi_tsfn

Fixes: nodejs/node-addon-api#556
PR-URL: nodejs/node-addon-api#58
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
tsfn: support direct calls to underlying napi_tsfn
c61a2ba 
support direct calls to underlying napi_tsfn

Fixes: nodejs/node-addon-api#556
PR-URL: nodejs/node-addon-api#58
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
tsfn: support direct calls to underlying napi_tsfn
453cecd 
support direct calls to underlying napi_tsfn

Fixes: nodejs/node-addon-api#556
PR-URL: nodejs/node-addon-api#58
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mateodelnorte @kfarnung @nschonni @vijaykumbhani @jasongin