Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] add documentation for handleScope class and EscapableHandleScope class #990

Closed
JckXia opened this issue May 2, 2021 · 5 comments
Closed

[Tests] add documentation for handleScope class and EscapableHandleScope class #990

JckXia opened this issue May 2, 2021 · 5 comments
Labels
good first issue never-stale test

Comments

@JckXia
Copy link
Member

JckXia commented May 2, 2021 •
edited
Loading

class methods
HandleScope
Covered #250 HandleScope(Napi::Env env)
HandleScope(napi_env env, napi_handle_scope scope)
Env()
EscapableHandleScope
EscapableHandleScope(napi_env env, napi_escapable_handle_scope scope)
Covered #250 EscapableHandleScope(Napi::Env env)
Covered #250 Value Escape(napi_value escape)
Env()
@NickNaso NickNaso added the test label May 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Aug 4, 2021
@NickNaso NickNaso removed the stale label Aug 4, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jan 12, 2022
@NickNaso NickNaso removed the stale label Jan 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label May 5, 2022
@NickNaso NickNaso removed the stale label May 5, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Nov 12, 2022
@NickNaso NickNaso removed the stale label Nov 12, 2022
@JckXia JckXia mentioned this issue Jan 4, 2023
Closed
@JckXia
Copy link
Member Author

JckXia commented Jan 13, 2023

Completed following #1263

@JckXia JckXia closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue never-stale test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add tests for escape and handlescope JckXia/node-addon-api
2 participants
@NickNaso @JckXia