fix: missing node_api_nogc_env definition #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 64.42% 64.42%
=======================================
Files 3 3
Lines 2010 2010
Branches 699 699
=======================================
Hits 1295 1295
Misses 147 147
Partials 568 568 ☔ View full report in Codecov by Sentry. |
NickNaso
reviewed
Oct 4, 2024
KevinEady
reviewed
Oct 4, 2024
napi.h
Outdated
| #if NAPI_VERSION > 5 | ||
| template <typename T> | ||
| static void DefaultFini(Env, T* data); | ||
| template <typename DataType, typename HintType> | ||
| static void DefaultFiniWithHint(Env, DataType* data, HintType* hint); | ||
| #endif // NAPI_VERSION > 5 | ||
| public: | ||
| BasicEnv(node_api_nogc_env env); | ||
| BasicEnv(node_addon_api_basic_env env); | ||
| #ifdef NODE_API_EXPERIMENTAL_HAS_POST_FINALIZER |
There was a problem hiding this comment.
In the node-addon-api meeting on 4 Oct, we discussed that it should be possible just to have a operator to node_addon_api_basic_env and node_addon_api_basic_finalize, as the compiler will allow conversion from BasicEnv -> node_addon_api_basic_env -> node_api_nogc_env or napi_env depending on options allowed.
There was a problem hiding this comment.
Updated, ptal again, thanks
NickNaso
approved these changes
Oct 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1584
Add GitHub Actions for
node-api-headerscompatibility test, covering old Node.js versions.node-api-headersstrips experimental apis so only test with stable NAPI_VERSION.As there was no feature detection defs for
node_api_basic_finalizeornode_api_basic_env, useNODE_API_EXPERIMENTAL_HAS_POST_FINALIZERfor feature detection since it was introduced about the time wherenode_api_basic_env/node_api_nogc_envwas introduced.