Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures with VS2022 #1491

Closed
mhdawson opened this issue May 2, 2024 · 4 comments
Closed

Failures with VS2022 #1491

mhdawson opened this issue May 2, 2024 · 4 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented May 2, 2024

I was just adding 23 to the matrix and noticed we should have added testing with VS2022 a while ago.

Seems like there are some failures - https://ci.nodejs.org/job/node-test-node-addon-api-new/nodes=win-vs2022/8773/
@mhdawson
Copy link
Member Author

mhdawson commented May 3, 2024

@vmoroz will take a look.

@vmoroz
Copy link
Member

vmoroz commented May 3, 2024

@mhdawson , the code uses std::allocator methods construct and destroy. They were deprecated in in C++17 and removed in C++20. See https://en.cppreference.com/w/cpp/memory/allocator/construct, https://en.cppreference.com/w/cpp/memory/allocator/destroy.
I will send a PR that fixes it.

@KevinEady
Copy link
Contributor

Is this fixed by #1492?

@mhdawson
Copy link
Member Author

We took a look at the CI runs in the meeting today and its fixed. Many thanks @vmoroz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vmoroz @KevinEady @mhdawson