Skip to content

Commit

Permalink
build: enable travis for fast PR check
Browse files Browse the repository at this point in the history
* test: remove unnecessary NAPI_EXPERIMENTAL
* travis: remove chakracore on travis

Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
legendecas authored and mhdawson committed Sep 20, 2019
1 parent 6192e70 commit 5d6aeae
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
15 changes: 8 additions & 7 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,15 @@ env:
# https://github.com/jasongin/nvs/blob/master/doc/CI.md
- NVS_VERSION=1.4.2
matrix:
- NODEJS_VERSION=node/4
- NODEJS_VERSION=node/6
- NODEJS_VERSION=node/8
- NODEJS_VERSION=node/9
- NODEJS_VERSION=node/10
- NODEJS_VERSION=chakracore/8
- NODEJS_VERSION=chakracore/10
- NODEJS_VERSION=node/12
- NODEJS_VERSION=nightly
- NODEJS_VERSION=chakracore-nightly
matrix:
fast_finish: true
allow_failures:
- env: NODEJS_VERSION=nightly
- env: NODEJS_VERSION=chakracore-nightly
sudo: false
cache:
directories:
Expand Down Expand Up @@ -59,7 +54,13 @@ install:
script:
# Travis CI sets NVM_NODEJS_ORG_MIRROR, but it makes node-gyp fail to download headers for nightly builds.
- unset NVM_NODEJS_ORG_MIRROR
- NODEJS_MAJOR_VERSION=$(node -p "process.versions.node.match(/\d+/)[0]")

- npm test $NPMOPT
- |
if [ ${NODEJS_MAJOR_VERSION} -gt 11 ]; then
npm test
else
npm test $NPMOPT --NAPI_VERSION=$(node -p "process.versions.napi")
fi
after_success:
- cpp-coveralls --gcov-options '\-lp' --build-root test/build --exclude test
1 change: 0 additions & 1 deletion test/basic_types/array.cc
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#define NAPI_EXPERIMENTAL
#include "napi.h"

using namespace Napi;
Expand Down

0 comments on commit 5d6aeae

Please sign in to comment.