test: test ObjectWrap destructor - no HandleScope

Add test for ObjectWrap destructor (no HandleScope exception) REFS: #722 PR-URL: #729 Reviewed-By: Michael Dawson <[email protected]>
nodejs · Aug 24, 2020 · 518cfdc · 518cfdc
1 parent c2cbbd9
commit 518cfdc
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/test/index.js b/test/index.js
@@ -55,6 +55,7 @@ let testModules = [
   'objectwrap_constructor_exception',
   'objectwrap-removewrap',
   'objectwrap_multiple_inheritance',
+  'objectwrap_worker_thread',
   'objectreference',
   'reference',
   'version_management'
@@ -90,6 +91,10 @@ if (napiVersion < 6) {
   testModules.splice(testModules.indexOf('typedarray-bigint'), 1);
 }
 
+if (majorNodeVersion < 12) {
+  testModules.splice(testModules.indexOf('objectwrap_worker_thread'), 1);
+}
+
 if (typeof global.gc === 'function') {
   (async function() {
   console.log(`Testing with N-API Version '${napiVersion}'.`);

diff --git a/test/objectwrap.cc b/test/objectwrap.cc
@@ -40,6 +40,14 @@ class Test : public Napi::ObjectWrap<Test> {
     info.This().As<Napi::Object>().DefineProperty(
         Napi::PropertyDescriptor::Accessor<OwnPropertyGetter>("ownPropertyT",
                                                               napi_enumerable, this));
+
+    bufref_ = Napi::Persistent(Napi::Buffer<uint8_t>::New(
+        Env(),
+        static_cast<uint8_t*>(malloc(1)),
+        1,
+        [](Napi::Env, uint8_t* bufaddr) {
+            free(bufaddr);
+        }));
   }
 
   static Napi::Value OwnPropertyGetter(const Napi::CallbackInfo& info) {
@@ -183,6 +191,8 @@ class Test : public Napi::ObjectWrap<Test> {
   Napi::FunctionReference finalizeCb_;
 
   static std::string s_staticMethodText;
+
+  Napi::Reference<Napi::Buffer<uint8_t>> bufref_;
 };
 
 std::string Test::s_staticMethodText;

diff --git a/test/objectwrap_worker_thread.js b/test/objectwrap_worker_thread.js
@@ -0,0 +1,14 @@
+'use strict';
+const buildType = process.config.target_defaults.default_configuration;
+const { Worker, isMainThread } = require('worker_threads');
+
+if (isMainThread) {
+    new Worker(__filename);
+} else {
+    const test = binding => {
+        new binding.objectwrap.Test();
+    };
+
+    test(require(`./build/${buildType}/binding.node`));
+    test(require(`./build/${buildType}/binding_noexcept.node`));
+}