Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: add new collaborators #V #1552

Closed
Fishrock123 opened this issue Apr 28, 2015 · 32 comments
Closed

governance: add new collaborators #V #1552

Fishrock123 opened this issue Apr 28, 2015 · 32 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Fishrock123
Copy link
Contributor

It's been a little too long.

Who wants to run this one? I'm willing to join in to help / prepare to possibly do future ones, but I can't quite answer the sort of questions some of the other TC members can quite yet. :) /cc @chrisdickinson

Thread is otherwise open for @iojs/tc to nominate folks for onboarding as per our governance. @iojs/collaborators, feel free to make suggestions.

Previous onboarding threads: [4], [3], [2], [1].

@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Apr 28, 2015
@chrisdickinson
Copy link
Contributor

I'm totally happy to run this one, or to help someone else run it if they're feeling up to it!

@Fishrock123
Copy link
Contributor Author

Nominating:

@ofrobots
@domenic (Similar to how I was added, he's been quite helpful.)

@chrisdickinson chrisdickinson changed the title governance: add new collaborators #IV governance: add new collaborators #V Apr 28, 2015
@chrisdickinson
Copy link
Contributor

From previous onboarding issues:

@mathiasbynens
@bk2204
@teppeis

@Fishrock123
Copy link
Contributor Author

Also: @monsanto

@amarkanala
Copy link

@amarkanala

@silverwind
Copy link
Contributor

@amarkanala self-nomination is probably not possible.

@Fishrock123
Copy link
Contributor Author

@amarkanala While it is possible to suggest yourself, it doesn't look like you have prior efforts on the project. Were you hoping to help with something specific? :)

@chrisdickinson
Copy link
Contributor

@silverwind It's okay (encouraged, even!) to suggest yourself if you're interested in becoming a collaborator. It doesn't necessarily mean you'll be onboarded on this round, but it's a good place to start to get guidance.

@chrisdickinson
Copy link
Contributor

For folks coming here from my tweets about this issue, here's how this process works:

Suggestions from community members (including self-suggestions) are welcome. It helps a lot if the person being suggested has a history of helping on IRC, the issue tracker, or within any of io.js' repos. Collaborators and TC members may nominate individuals from those suggestions for onboarding. They may also nominate individuals outside of those suggestions.

After this issue has been open for 48-72 hours, the person in charge of onboarding (usually me, but possibly @Fishrock123 this time) will put up a list of the candidates to be onboarded, and a doodle poll for them to fill out. For large groups, we'll usually split the pool into groups of 5-6, and pick two times from the poll. There's a 45-60 minute google hangout with each of the smaller groups where someone will cover basics of setting up the project, governance, M.O. of the issue tracker, and other topics. Then the new collaborators are added to the repo and given the task of adding themselves to the README.

In the past we've limited suggestions to the TC and existing collaborators. However I suspect there are quality potential candidates we're missing out on either because we don't know about them, or because they aren't aware of this process. So, this time around I put the question to the community at large (or at least, as "at large" as I can reach on Twitter and the issue tracker.)

If you don't make it in this round, don't despair! This is a recurring process. If you have questions about why you weren't included in the current batch, please direct them to my github email and I'd be happy to answer them.

Again, if you feel uncomfortable self-promoting, don't hesitate to contact me via my email.

@bk2204
Copy link
Contributor

bk2204 commented Apr 29, 2015

Again, while I do appreciate the offer, I'd like to submit more patches and get more familiar with the codebase before accepting a more formal role. My patch was more of a one-off submission, but that doesn't mean that I might not contribute more in the future if I have more time.

@chrisdickinson
Copy link
Contributor

@bk2204 Ah, totally cool. Sorry to bug you again!

@jbergstroem
Copy link
Member

I'd like to suggest @zcbenz which seems to be the main driver of io.js/node in atom. Their agenda as well as making sure they carry less patches on top of io.js seems like a great fit.

@silverwind
Copy link
Contributor

Suggesting @rlidwka, a long time contributor.

@brendanashworth
Copy link
Contributor

Suggesting @Olegas

@rvagg
Copy link
Member

rvagg commented May 2, 2015

How about this for a process suggestion -- when nominating someone, could you point to some of their previous contributions, or give a full name or email address for which we can look through the git log and see for ourselves. I see a bunch of usernames here that I don't recognise and it could be that I'm not following as closely at the moment.

i.e. can we have justifications for nominations please and not just someone that you think would be a rad addition because they are inherently rad, part of open governance and sharing ownership of the project is earning that ownership and there has to be a clear path that outsiders can see happening.

@jbergstroem
Copy link
Member

@rvagg good idea. how about adding a note to the collaborator guide about this?

edit: contributor -> collaborator

@chrisdickinson
Copy link
Contributor

@jbergstroem I'm working on collaborator onboarding docs over here at the moment.

@rlidwka
Copy link
Contributor

rlidwka commented May 3, 2015

or give a full name or email address for which we can look through the git log and see for ourselves

You can check previous commits by copy-pasting nickname into an url like this:
https://github.com/iojs/io.js/commits?author=rvagg

It's probably more useful 'cause people might have committed from multiple email addresses, and github should take care of all that.

@domenic
Copy link
Contributor

domenic commented Jun 1, 2015

I'd be honored.

@ChALkeR
Copy link
Member

ChALkeR commented Jun 1, 2015

I would be happy too, thanks.

@ofrobots
Copy link
Contributor

ofrobots commented Jun 4, 2015

I'd be happy as well.

@jbergstroem
Copy link
Member

Wow, great additions 👍

@Olegas
Copy link
Contributor

Olegas commented Jun 4, 2015

Thanks!

@chrisdickinson
Copy link
Contributor

Cool – it looks like we have more than enough folks to get onboarded. Would the following people fill out their availability on this doodle?

It's possible we'll end up with two groups for onboarding. Additionally, if any of you will be at Nodeconf, I'd be happy to run an impromptu onboarding session there.

Once folks have selected times, I'll announce the onboarding groups on this thread. Shortly before your onboarding time, you'll receive an email* with a Google Hangout link and some information about the content of the onboarding. Thanks for your contributions to io.js!

*: I'll be using the email associated with your GitHub account. If you have an alternate account you'd rather not share publicly, email me at christopher.s.dickinson at gmail dot com.

@Olegas
Copy link
Contributor

Olegas commented Jun 5, 2015

Done.
Email for hangouts: [email protected]

@monsanto
Copy link
Contributor

monsanto commented Jun 5, 2015

I'm happy to accept with the caveat that my time for open source can be a bit sporadic.

@chrisdickinson
Copy link
Contributor

It looks like we'll be able to do a single onboarding group at 1PM PDT (8PM UTC) this coming Tuesday, June 9th. An invite has been sent out. Thanks, all!

@Fishrock123 Would you like to schedule a separate time to do a hangout/run-through of the onboarding process so that you can run the next one?

@Fishrock123
Copy link
Contributor Author

@chrisdickinson want to just do it at nodeconf, or?

@chrisdickinson
Copy link
Contributor

And we're done! Thanks all!

@Fishrock123 Yep, that sounds great!

@Fishrock123
Copy link
Contributor Author

Just noticed how long this thread was open, will have to open another soon to get @Trott in! :)

@rvagg
Copy link
Member

rvagg commented Jun 10, 2015

a PR that's ready to merge with two LGTM's that would be a good candidate for a new collaborator wanting to practice merging: #1877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests