Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: support new syntax for uncertain metadata #23

Closed
joyeecheung opened this issue Nov 5, 2017 · 2 comments
Closed

feature request: support new syntax for uncertain metadata #23

joyeecheung opened this issue Nov 5, 2017 · 2 comments

Comments

@joyeecheung
Copy link
Member

Refs: https://github.com/joyeecheung/node-core-utils/pull/72#pullrequestreview-74269096

If the tool generating the metadata is not sure about something, it can put a ? before the metadata, and let core-validate-commit complain. For example, if someone LGTM via comments, the tool can generate the reviewer as:

?Reviewed-By: someone <[email protected]>
@joyeecheung
Copy link
Member Author

joyeecheung commented Nov 5, 2017 •
edited
Loading

cc @nodejs/automation see if anyone is interested in picking this one up. This would need an update in lib/rules/*.js and an update in https://github.com/git-lint/gitlint-parser-node as well (because that's where the context comes from)

@joyeecheung joyeecheung changed the title Support new syntax for uncertain metadata feature request: support new syntax for uncertain metadata Nov 5, 2017
@riyadhalnur
Copy link

riyadhalnur commented Nov 5, 2017 •
edited
Loading

I'll pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riyadhalnur @joyeecheung