Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new CI job for linting and doc tests #929

Closed
joyeecheung opened this issue Oct 22, 2017 · 3 comments
Closed

A new CI job for linting and doc tests #929

joyeecheung opened this issue Oct 22, 2017 · 3 comments

Comments

@joyeecheung
Copy link
Member

Previously #887 , also see nodejs/node#16208 (comment)

We can also consider joining linter CI and doc CI in a new CI job. Previously, we used linter CI also for benchmark PRs, but now we tend to make benchmarks fully testable, so the separate linter CI job remains useful only for the docs with code fragments. We can as well make these two CI joined in some special light CI job for docs.

I would like to help get this one set up.

@gibfahn
Copy link
Member

gibfahn commented Oct 22, 2017

Okay, so how should we do this?

I guess options are:

  1. Run doc linting as part of the regular linter job, and then just run the linter only on doc PRs.
  2. Have a new job to run the doc linting, and then have an option in node-test-pull-request to only run linter + doc linter (off by default).

How do you run the doc linting btw? I should really know, but I'm not sure. Is it a make target?

@joyeecheung
Copy link
Member Author

@gibfahn A make target indeded.See nodejs/node#16377 (need to fix the shell quirks first)

@joyeecheung
Copy link
Member Author

It's already up and running in https://ci.nodejs.org/job/node-test-pull-request-lite/. This can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants